fixed crash if dependency is missing reference

that shouldn't be possible and afaict has only been reported once fixes #14351
Nexus-Mods · May 23, 2023 · f33502a · f33502a
1 parent de4797a
commit f33502a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/extensions/mod_management/InstallManager.ts b/src/extensions/mod_management/InstallManager.ts
@@ -2401,7 +2401,7 @@ class InstallManager {
           : this.withInstructions(api,
                               modName(sourceMod),
                               renderModReference(dep.reference),
-                              dep.reference.tag ?? downloadId,
+                              dep.reference?.tag ?? downloadId,
                               dep.extra?.['instructions'],
                               recommended, () =>
           this.installModAsync(dep.reference, api, downloadId,

diff --git a/src/extensions/mod_management/util/modName.ts b/src/extensions/mod_management/util/modName.ts
@@ -46,13 +46,17 @@ export interface IRenderOptions {
   version?: boolean;
 }
 
-export function renderModReference(ref: IModReference, mod?: IMod, options?: IRenderOptions) {
+export function renderModReference(ref?: IModReference, mod?: IMod, options?: IRenderOptions) {
   const version = (options === undefined) || options.version !== false;
 
   if (mod !== undefined) {
     return modName(mod, { version });
   }
 
+  if (ref === undefined) {
+    return '<Invalid reference>';
+  }
+
   if (ref.description !== undefined) {
     return ref.description;
   }