Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mostly working app on MacOS #2352

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Mostly working app on MacOS #2352

wants to merge 8 commits into from

Conversation

halgari
Copy link
Collaborator

@halgari halgari commented Dec 6, 2024

Somehow it all clicked once I got a box that can actually build the app. This does the following:

  • Moves standard app logic into NexusMods.App.Common
  • Makes NexusMods.App now purely focused on Windows/Linux support. It still targets base net-9.0, and WinExe
  • Adds NexusMods.App.MacOS that is a net9.0-macos app focused on settings and startup utilities needed for mac support
  • Adds to the above project the Info.plist settings required for URL dispatching and setup of icons
  • Adds the proper Iconset files
  • Adds a python script for resizing images for the iconset (this is rarely needed)
  • Adds changes to the core of the Avalonia startup to handle URL events. This is now cross-platform, but I'm not aware of any other OSes that send files this way.
  • Fixes a bug with URL opening on macOS when the URL contains spaces (like login URLs do)

There's still a few bugs here. The app crashes in release mode, and the 7zz files aren't getting copied into the app bundle. I'll research that later. But this is miles ahead of anything we've had so far.

Next week I'll make sure this doesn't break anything in the other OSes, but it's looking good so far.

@halgari halgari marked this pull request as ready for review December 6, 2024 04:44
@DarthMDev
Copy link

Lets go well done 👏 ill try to look into those issues when i can if you don't beat me to it

Copy link
Contributor

github-actions bot commented Dec 9, 2024

This PR conflicts with main. You need to rebase the PR before it can be merged.

@github-actions github-actions bot added the status-needs-rebase Set by CI do not remove label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status-needs-rebase Set by CI do not remove
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants