From 4a4c3ad365543b31cfc1e40fd49caccbe544cff3 Mon Sep 17 00:00:00 2001
From: "Lars H. Rohwedder" <RokerHRO@users.noreply.github.com>
Date: Mon, 6 May 2024 21:19:15 +0200
Subject: [PATCH] buffer is 'const void*' in output functions, as in write(2),
 fwrite(3) etc.

---
 cliserv.c    |  2 +-
 cliserv.h    |  2 +-
 nbd-server.c | 10 +++++-----
 nbdsrv.h     |  2 +-
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/cliserv.c b/cliserv.c
index 46a790e6..9341e606 100644
--- a/cliserv.c
+++ b/cliserv.c
@@ -139,7 +139,7 @@ int readit(int f, void *buf, size_t len) {
  * @param len the number of bytes to be written
  * @return 0 on success, or -1 if the socket was closed
  **/
-int writeit(int f, void *buf, size_t len) {
+int writeit(int f, const void *buf, size_t len) {
 	ssize_t res;
 	while (len > 0) {
 		DEBUG("+");
diff --git a/cliserv.h b/cliserv.h
index 8a89c044..b8e79786 100644
--- a/cliserv.h
+++ b/cliserv.h
@@ -89,7 +89,7 @@ uint64_t ntohll(uint64_t a);
 #endif
 
 int readit(int f, void *buf, size_t len);
-int writeit(int f, void *buf, size_t len);
+int writeit(int f, const void *buf, size_t len);
 
 #define NBD_DEFAULT_PORT	"10809"	/* Port on which named exports are
 					 * served */
diff --git a/nbd-server.c b/nbd-server.c
index 3749b74a..60fc5a59 100644
--- a/nbd-server.c
+++ b/nbd-server.c
@@ -301,7 +301,7 @@ struct generic_conf {
 };
 
 #if HAVE_GNUTLS
-static int writeit_tls(gnutls_session_t s, void *buf, size_t len) {
+static int writeit_tls(gnutls_session_t s, const void *buf, size_t len) {
 	_cleanup_g_free_ char *m = NULL;
 	ssize_t res;
 	while(len > 0) {
@@ -345,7 +345,7 @@ static int socket_read_tls(CLIENT* client, void *buf, size_t len) {
 	return readit_tls(*((gnutls_session_t*)client->tls_session), buf, len);
 }
 
-static int socket_write_tls(CLIENT* client, void *buf, size_t len) {
+static int socket_write_tls(CLIENT* client, const void *buf, size_t len) {
 	return writeit_tls(*((gnutls_session_t*)client->tls_session), buf, len);
 }
 #endif // HAVE_GNUTLS
@@ -354,7 +354,7 @@ static int socket_read_notls(CLIENT* client, void *buf, size_t len) {
 	return readit(client->net, buf, len);
 }
 
-static int socket_write_notls(CLIENT* client, void *buf, size_t len) {
+static int socket_write_notls(CLIENT* client, const void *buf, size_t len) {
 	return writeit(client->net, buf, len);
 }
 
@@ -397,7 +397,7 @@ static inline void consume_len(CLIENT* c) {
 	consume(c, len, buf, sizeof(buf));
 }
 
-static void socket_write(CLIENT* client, void *buf, size_t len) {
+static void socket_write(CLIENT* client, const void *buf, size_t len) {
 	g_assert(client->socket_write != NULL);
 	if(client->socket_write(client, buf, len)<0) {
 		g_assert(client->socket_closed != NULL);
@@ -1790,7 +1790,7 @@ void punch_hole(int fd, off_t off, off_t len) {
 	}
 }
 
-static void send_reply(CLIENT* client, uint32_t opt, uint32_t reply_type, ssize_t datasize, void* data) {
+static void send_reply(CLIENT* client, uint32_t opt, uint32_t reply_type, ssize_t datasize, const void* data) {
 	struct {
 		uint64_t magic;
 		uint32_t opt;
diff --git a/nbdsrv.h b/nbdsrv.h
index 8aeec83f..4590c862 100644
--- a/nbdsrv.h
+++ b/nbdsrv.h
@@ -78,7 +78,7 @@ typedef struct _client {
 	void *tls_session;	/**< TLS session context. Is NULL unless STARTTLS
 				     has been negotiated. */
 	int (*socket_read)(struct _client*, void* buf, size_t len);
-	int (*socket_write)(struct _client*, void* buf, size_t len);
+	int (*socket_write)(struct _client*, const void* buf, size_t len);
 	void (*socket_closed)(struct _client*);
 } CLIENT;