Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate whether SycnTransaction and BufferedTransaction can be removed in favour of db/pebble/transaction.go #1782

Open
IronGauntlets opened this issue Apr 2, 2024 · 0 comments
Labels
DB Database

Comments

@IronGauntlets
Copy link
Contributor

Most likely there will only be one DB hence the SyncTransaction and BufferedTransaction abstractions may not be required. Instead, we should rely on the underlying DB implementation to provide the required functionality. Pebble already has a concept of Batch which is intended to batch multiple writes together before flushing to disk. The SyncTransaction explicitly uses a mutex to control the write and read operations, this should be ensured by the underlying db without further abstractions.

@IronGauntlets IronGauntlets added the DB Database label Apr 2, 2024
@kirugan kirugan assigned kirugan and unassigned kirugan Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB Database
Projects
None yet
Development

No branches or pull requests

2 participants