Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Goerli from Juno codebase #1758

Open
10 tasks
rianhughes opened this issue Mar 21, 2024 · 2 comments
Open
10 tasks

Remove Goerli from Juno codebase #1758

rianhughes opened this issue Mar 21, 2024 · 2 comments
Labels
Good first issue Good for newcomers

Comments

@rianhughes
Copy link
Contributor

rianhughes commented Mar 21, 2024

Context: the Goerli network is being deprecated, but Juno tests still rely on it. The tests that rely on Goerli should be updated to use the Sepolia network instead.

RPC based tests that require Goerli:

  • TestClassV0
  • TestTransaction
  • TestHeight
  • TestBlockByNumberAndHash
  • TestEvents
  • TestChainId
  • TestBlockTransactionCount
  • TestBlockWithTxHashes
  • TestEvents
  • TestRpcBlockAdaptation

Goerli is used in other non-rpc tests (sn2core, blockchian, cmd, etc). These should also be updated, but the RPC tests might be a good place for newcomers to start

Note: any newcomers that are interested in working on this issue, should 1) open a new issue stating which test they want to fix, 2) create a new working branch, 3) implement the fix, 4) create a new PR, and assign someone form the Juno team to review it.

Note: these tasks need done before April 11th (Goerli testnet support will be removed April 11, 2024.)

@stefanalfbo
Copy link
Contributor

Hi, all the tests concerning the rpc package do not include any of the goerli networks anymore.

However the following tests are still using the goerli network as a reference:

@scarfacedotcom
Copy link

Can i take this one up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Good for newcomers
Projects
Status: In Review
Development

No branches or pull requests

3 participants