Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add develop tag to docker hub image #84

Open
yaron-idan opened this issue Dec 18, 2017 · 4 comments
Open

Add develop tag to docker hub image #84

yaron-idan opened this issue Dec 18, 2017 · 4 comments

Comments

@yaron-idan
Copy link

Right now docker hub only allows pulling releases of hubcommander.
Could be very handy to be able to pull the develop branch directly, instead of waiting for a new release.
Right now if I want to deploy the develop branch I have to build the image myself, which is pretty easy thanks to the great build-docker.sh script, but having develop available for me directly from docker hub would be nice.
Thanks,
Yaron.

@mikegrima
Copy link
Contributor

Agree -- this would be nice to have.

@yaron-idan
Copy link
Author

Hey @mikegrima, could I please get feedback for the PR I've opened (#85)?
Thanks.

@mikegrima
Copy link
Contributor

Merged it in. Thank you for the PR!

I think the last main portion is to modify: https://github.com/Netflix/hubcommander/blob/develop/publish_via_travis.sh#L36-L49 this so that we have a tag for stable/release, and one for unstable/development.

@yaron-idan
Copy link
Author

True, I was in the mindset of creating an automated build in docker hub but your solution fits better with the current CI, I'll open another PR for it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants