Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bouncy Castle dependency - replaceable with in-box cryptography? #461

Open
christophwille opened this issue Jun 3, 2023 · 4 comments
Open

Comments

@christophwille
Copy link
Contributor

The four assemblies for netsparkle come in at 3.46MB, with Bouncy Castle accounting for 3.16 (2.2.2 WPF .Core distribution). That is quite a hefty "penalty" - what is Bouncy Castle used for (ie would it be possible to at least replace it on .NET (Core) with in-box cryptography?)

@christophwille christophwille changed the title Bouncy Castle dependency - replacable with in-box cryptography? Bouncy Castle dependency - replaceable with in-box cryptography? Jun 3, 2023
@christophwille
Copy link
Contributor Author

christophwille commented Jun 3, 2023

Unless I am mistaken, there is only one place in the main package, namely https://github.com/NetSparkleUpdater/NetSparkle/blob/develop/src/NetSparkle/SignatureVerifiers/Ed25519Checker.cs (AppCast generation isn't something I am concerned about as this is a dev dependency).

@Deadpikle
Copy link
Collaborator

Deadpikle commented Jun 4, 2023

You're not mistaken. That's the one place where it is used.

If you can point me to a library that is similarly trustworthy and unit tested, or a built-in way to do this in .NET that works from 4.5.2 (or 4.6.2) all the way through .NET 7+, I'd be interested in taking a look.

Alternatively, would trimming the DLL in your own application (and making sure NetSparkle was trimmable) be the solution, here? It seems as though that would allow us to continue to use BouncyCastle (with its benefits and google-ability) while not bogging down published apps.

Edit: Links for future ref: bcgit/bc-csharp#451, bcgit/bc-csharp#422

@Deadpikle
Copy link
Collaborator

Some additional applicable old discussion here: #98

@christophwille
Copy link
Contributor Author

Isn't NSec doing just that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants