Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fit headers and footer dropdowns into the omnitable #58

Closed
plequang opened this issue Oct 11, 2017 · 2 comments
Closed

Fit headers and footer dropdowns into the omnitable #58

plequang opened this issue Oct 11, 2017 · 2 comments

Comments

@plequang
Copy link
Contributor

Description

Some column headers are using dropdowns by mean of https://www.webcomponents.org/element/PolymerElements/paper-dropdown-menu.

The paper-dropdown-menu's use default vertical-align=top, and horizontal-align is left for the first column, right for others.

We should rather use dynamic-align with fit-into properties from iron-dropdown in order to have the dropdown align and fit into the table dynamically.

However, this will be possible only when fit-into will be exposed by paper-menu-button and paper-dropdown-button, as explained in these issues:

Corresponding PRs:

When these issues are fixed, we will have to expose a reference to the omnitable in the header template instances, and bind fit-into to that property in paper-dropdown-menus.

@plequang
Copy link
Contributor Author

Unfortunately, seems no one in Polymer team wants to merge the PRs.

We might have to investigate to find another solution

@megheaiulian
Copy link
Collaborator

@plequang We can do this manually. We listen to one of the events and set paperDropdownMenu.$.menuButton.$.dropdown.fitInto = this.
I will open up a PR for this.

plequang pushed a commit that referenced this issue Feb 21, 2018
* Fit dropdowns into omnitable

* Fit bottomBar's menu into omnitable

Fixes #58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants