-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minsdk requirement set too high in Theme preferences #567
Comments
I'm already aware of these facts, but can't see the value of investing such effort in half-baked, hacky implementations to backport such secondaries or in supporting android versions, that are as good as dead. That said, maintainable code contributions are still welcome. |
About supporting follow night mode on low version android,we don't need to do anything about hacky backport .just delete the 'if' judgement and put the action on the above,then everything else will work ok. |
Neo-Store/src/main/kotlin/com/machiav3lli/fdroid/content/PrefsMetaData.kt
Lines 107 to 110 in 90ce6fe
Actually android support dark mode since 4.1 .However ,switch been added in AOSP system settings and tile not untill android 10.
So many third party apps can do this switch without root bellow api 29,such as
Darktheme
night-mode-tile
Dark-Mode-Switch
Considered neo-store 's minsdk has setted to 23 and would be 24 in 1.0 version, i suggest delete this judgement that users bellow api 29 with these little tools can also switch theme follow system.
We can guess the amount of users have this need from the downloads of this tool.
Neo-Store/src/main/kotlin/com/machiav3lli/fdroid/content/PrefsMetaData.kt
Lines 111 to 116 in 90ce6fe
Actually android support pick color from wallpaper since api 27,android 12 just give it a default implement.
https://developer.android.com/reference/android/app/WallpaperColors
So we can also lower this minsdk requirement to at least 28.
Google always do these thing that implement a function in early,but test and hide it for years .Then introduce it as a new feature officially after years to attract people's eyes.😀
The text was updated successfully, but these errors were encountered: