-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Base.alignment
for our ring element types?
#1415
Comments
I like this very much. Would it even be a good idea to give a default to all
with some special dispatches for e.g. julia> Rx, x = polynomial_ring(GF(2), "x")
(Univariate polynomial ring in x over GF(2), x)
julia> a = x^2+3x-4
x^2 + x
julia> [a,a^2,a^3,a^4,a^5]
5-element Vector{fpPolyRingElem}:
x^2 + x
x^4 + x^2
x^6 + x^5 + x^4 + x^3
x^8 + x^4
x^10 + x^9 + x^6 + x^5 If not, I would only do it for certain types like originally proposed, but additionally for things like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I just noticed the differing alignment in this example:
To improve our output, we could implement
Base.alignment
methods for our ring types.A naive implementation for our integers and rationals could look like this:
which results in this output:
The text was updated successfully, but these errors were encountered: