Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An unified interface for different wallets #16

Open
hurui200320 opened this issue Sep 7, 2021 · 0 comments
Open

An unified interface for different wallets #16

hurui200320 opened this issue Sep 7, 2021 · 0 comments

Comments

@hurui200320
Copy link
Contributor

Now we have two wallets as dapp API providers: WalletConnet and NeoLine. In the future, we might need to implement the O3 wallet. Each wallet has its own js API and requires a different approach to use, which introduce a lot of pain to make all of those wallet supported in the codebase.

Thus we need a unified interface for those wallets, which should have minimum features that satisfied the app's need, like sending a transaction, get a notification when tx is confirmed, etc., and some basic features, like connecting/init the wallet, reading the account address and converting into script hash, etc.

That is a scratch, we need to define each feature's interface (parameters and returned value) and behavior (when to throw what exception). Also, make sure it can be implemented by most of the wallets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant