Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NS7: Shared files get generated on NS-only projects. #309

Open
OscarMeier opened this issue Jan 7, 2021 · 2 comments
Open

NS7: Shared files get generated on NS-only projects. #309

OscarMeier opened this issue Jan 7, 2021 · 2 comments

Comments

@OscarMeier
Copy link

Environment

OS: win32 x64
Node: 12.18.2
NativeScript: 7.0.11
Angular CLI: 11.0.5

Describe the bug

The isWeb method returns true if there is a nativescript.config.ts file:

const isWeb = (tree: Tree) => {

In NS7 projects the configs are all consolidated into a single nativescript.config.ts per default also in NS-only projects. Therefore the ng-CLI generates shared files in NS7 projects:

$ ng g m test
CREATE src/app/test/test.module.ts (190 bytes)
CREATE src/app/test/test.module.tns.ts (269 bytes)
CREATE src/app/test/test.common.ts (177 bytes)

Expected behavior
The isWeb method should check the shared attribute of the NativeScriptConfig in NS7 projects.

@agonper
Copy link
Contributor

agonper commented Apr 21, 2021

This is fixed in #314

@agonper
Copy link
Contributor

agonper commented Apr 21, 2021

I guess this issue can be closed now @NathanWalker 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants