Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console.log should not call object methods #1693

Open
jerbob92 opened this issue Dec 20, 2021 · 0 comments
Open

console.log should not call object methods #1693

jerbob92 opened this issue Dec 20, 2021 · 0 comments

Comments

@jerbob92
Copy link

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

  • CLI: 8.1.5
  • Cross-platform modules: 6.5.11
  • Android Runtime: 6.5.3
  • iOS Runtime (if applicable): Possibly irrelevant
  • Plugin(s): Possibly irrelevant

Describe the bug
When an object contains a toString or toJSON method, and you print that object through console.log, it will automatically call that function. This is very different from what Chrome console.log does and may cause confusing behavior. For example:
The NativeScript HTTP client returns an object with a property called content that contains an object with a to toJSON method, when you console.log the return object, it will automatically call that toJSON method, while it might not even be JSON, causing the console.log to fail with a weird error from JSON.parse, like Unexpected end of JSON input.

To Reproduce

const randomVar = "test123";
const obj = {
	toJSON: () => "toJSON => this should not be logged " + randomVar
};

console.log(obj);

Expected behavior
I think it should print something like:

{
  "toJSON": ƒ
}

Or, it should catch any errors that happen during the format, and then fall back to it's normal behavior (going to toString, or not printing the property at all). It should not be breaking off the whole console.log and return the exception.

Additional context
Output when doing something like this in Chrome:
image

Output when doing something like this in NS:
image

When causing an error inside the function with:

const obj = {
	toJSON: () => JSON.parse("fakejson")
};

console.log(obj);

In Chrome:
image

In NS:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant