Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minHour and minMinute crash the app on TimePicker #10483

Open
mBaldasty opened this issue Jan 25, 2024 · 1 comment
Open

minHour and minMinute crash the app on TimePicker #10483

mBaldasty opened this issue Jan 25, 2024 · 1 comment
Labels
bug-pending-triage Reported bug, pending triage to confirm.

Comments

@mBaldasty
Copy link

Issue Description

when setting a minMinute like 17 and trying to set a minute like 15 the app crashes with the error

***** Fatal JavaScript exception - application has been terminated. ***** NativeScript encountered a fatal error: Uncaught Error: minute property value (15:15) is not valid. Min time: (17:17), max time: (23:59). at valueChanged(file: @projectroute/webpack:/@nativescript/template-blank-vue/node_modules/@nativescript/core/ui/time-picker/time-picker-common.js:134:0) at Property.nativeValueChange(file: @projectroute/webpack:/@nativescript/template-blank-vue/node_modules/@nativescript/core/ui/core/properties/index.js:222:0) at UITimePickerChangeHandlerImpl.valueChanged(file: @projectroute/webpack:/@nativescript/template-blank-vue/node_modules/@nativescript/core/ui/time-picker/index.ios.js:126:12)

Reproduction

<TimePicker row="0"
ref="content-wrapper2"
class="accordion-content"
color="black"
iosPreferredDatePickerStyle="1"
minHour="15"
minMinute="30"
locale="de"

            />

Just use this and try to set the minutes below 30 or the hour below 15

Relevant log output (if applicable)

***** Fatal JavaScript exception - application has been terminated. *****
  NativeScript encountered a fatal error:
  Uncaught Error: minute property value (15:15) is not valid. Min time: (17:17), max time: (23:59).
   at
        valueChanged(file: @projectroute/webpack:/@nativescript/template-blank-vue/node_modules/@nativescript/core/ui/time-picker/time-picker-common.js:134:0)
        at Property.nativeValueChange(file: @projectroute/webpack:/@nativescript/template-blank-vue/node_modules/@nativescript/core/ui/core/properties/index.js:222:0)
        at UITimePickerChangeHandlerImpl.valueChanged(file: @projectroute/webpack:/@nativescript/template-blank-vue/node_modules/@nativescript/core/ui/time-picker/index.ios.js:126:12)

Environment

`OS: macOS 13.4.1
CPU: (10) arm64 Apple M1 Pro
Shell: /bin/zsh
node: 18.16.0
npm: 9.5.1
nativescript: 8.6.5

android

java: 11.0.18
ndk: Not Found
apis: 28, 29, 30, 31, 32, 33, 33
build_tools: 29.0.3, 30.0.0, 30.0.3, 32.0.0, 33.0.0, 33.0.1, 33.0.2
system_images:

  • android-27 | Google APIs ARM 64 v8a
  • android-28 | Google APIs ARM 64 v8a
  • android-29 | Google APIs ARM 64 v8a
  • android-31 | ARM 64 v8a
  • android-32 | Google APIs ARM 64 v8a

ios

xcode: 14.3/14E222b
cocoapods: 1.12.0
python: 3.11.4
python3: 3.11.4
ruby: 2.7.7
platforms:

  • DriverKit 22.4
  • iOS 16.4
  • macOS 13.3
  • tvOS 16.4
  • watchOS 9.4

### Dependencies

```json
"dependencies": {
  "@klippa/nativescript-http": "3.0.4",
  "@nativescript-community/drawingpad": "4.1.0",
  "@nativescript-community/gps": "3.1.10",
  "@nativescript-community/perms": "2.3.0",
  "@nativescript-community/text": "1.5.31",
  "@nativescript-community/tween": "0.0.14",
  "@nativescript-community/ui-canvas": "4.5.1",
  "@nativescript-community/ui-canvaslabel": "1.2.2",
  "@nativescript-community/ui-chart": "1.2.29",
  "@nativescript-community/ui-collectionview": "5.1.9",
  "@nativescript-community/ui-collectionview-swipemenu": "5.1.9",
  "@nativescript-community/ui-drawer": "0.1.18",
  "@nativescript-community/ui-image": "4.3.10",
  "@nativescript-community/ui-label": "1.3.7",
  "@nativescript-community/ui-material-activityindicator": "7.1.3",
  "@nativescript-community/ui-material-button": "7.1.3",
  "@nativescript-community/ui-material-dialogs": "7.1.3",
  "@nativescript-community/ui-material-ripple": "7.1.3",
  "@nativescript-community/ui-material-snackbar": "7.1.3",
  "@nativescript-community/ui-material-tabs": "7.1.3",
  "@nativescript-community/ui-material-textfield": "7.1.3",
  "@nativescript-community/ui-material-textview": "7.1.3",
  "@nativescript-community/ui-pager": "14.1.6",
  "@nativescript-community/ui-pulltorefresh": "2.5.3",
  "@nativescript-community/ui-svg": "0.1.11",
  "@nativescript-community/ui-webview": "1.4.9",
  "@nativescript-community/ui-zoomimage": "4.3.9",
  "@nativescript-community/universal-links": "3.0.0",
  "@nativescript/background-http": "6.0.0",
  "@nativescript/biometrics": "1.3.1",
  "@nativescript/camera": "5.0.15",
  "@nativescript/canvas": "1.1.0",
  "@nativescript/contacts": "2.1.0",
  "@nativescript/core": "8.6.2",
  "@nativescript/datetimepicker": "2.1.13",
  "@nativescript/firebase-core": "3.1.3",
  "@nativescript/firebase-messaging": "3.1.3",
  "@nativescript/firebase-messaging-core": "3.1.3",
  "@nativescript/geolocation": "8.2.1",
  "@nativescript/google-maps": "1.5.2",
  "@nativescript/imagepicker": "2.0.2",
  "@nativescript/iqkeyboardmanager": "2.1.1",
  "@nativescript/local-notifications": "6.1.1",
  "@nativescript/mlkit-barcode-scanning": "2.0.0",
  "@nativescript/mlkit-core": "2.0.0",
  "@nativescript/pdf": "1.0.1",
  "@nativescript/theme": "~3.0.1",
  "@nativescript/zip": "^6.0.0",
  "@nstudio/nativescript-blur": "3.0.2",
  "@nstudio/nativescript-camera-plus": "4.2.0",
  "@nstudio/nativescript-exoplayer": "^6.1.0",
  "@nstudio/nativescript-shimmer": "1.0.7",
  "@triniwiz/nativescript-image-cache-it": "7.3.0",
  "@triniwiz/nativescript-image-zoom": "4.2.0",
  "@triniwiz/nativescript-nested-scrollview": "2.0.2",
  "@types/jspdf": "^2.0.0",
  "assert": "2.0.0",
  "axios": "0.21.1",
  "base-64": "^1.0.0",
  "browserify-zlib": "0.2.0",
  "buffer": "^6.0.3",
  "copy-webpack-plugin": "11.0.0",
  "https-browserify": "1.0.0",
  "jspdf": "^2.5.1",
  "nativescript-dynamsoft-camera-enhancer": "1.1.2",
  "nativescript-inappbrowser": "^3.2.0",
  "nativescript-intl": "4.0.2",
  "nativescript-perms": "^2.0.11",
  "nativescript-ui-calendar": "15.2.3",
  "nativescript-ui-listview": "15.2.3",
  "nativescript-vue": "2.9.3",
  "os-browserify": "0.3.0",
  "pdfkit": "^0.13.0",
  "pdfmake": "^0.2.6",
  "stream-browserify": "3.0.0",
  "stream-http": "^3.2.0",
  "tty-browserify": "0.0.1",
  "typescript": "^5.2.2",
  "url": "0.11.0",
  "util": "0.12.4",
  "vuex": "3.6.2"
},
"devDependencies": {
  "@nativescript/android": "8.6.2",
  "@nativescript/ios": "8.6.3",
  "@nativescript/types": "8.5.0",
  "@nativescript/webpack": "5.0.18",
  "nativescript-vue-template-compiler": "2.9.3",
  "postcss-loader": "7.1.0"
}
`

### Please accept these terms

- [X] I have searched the [existing issues](https://github.com/NativeScript/NativeScript/issues) as well as [StackOverflow](https://stackoverflow.com/questions/tagged/nativescript) and this has not been posted before
- [X] This is a bug report
- [X] I agree to follow this project's [Code of Conduct](https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#coc)
@mBaldasty mBaldasty added the bug-pending-triage Reported bug, pending triage to confirm. label Jan 25, 2024
@fpaaske
Copy link

fpaaske commented Apr 30, 2024

Probably related to this issue: #7350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-pending-triage Reported bug, pending triage to confirm.
Projects
None yet
Development

No branches or pull requests

2 participants