Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NativeDialogService does not format colors on Spans embedded inside Labels #10423

Open
3 tasks done
CodeWitchJosie opened this issue Oct 25, 2023 · 0 comments
Open
3 tasks done
Labels
bug-pending-triage Reported bug, pending triage to confirm.

Comments

@CodeWitchJosie
Copy link

CodeWitchJosie commented Oct 25, 2023

Issue Description

In iOS only, for Angular, when converting from ModalDialogService to NativeDialogService, color styles are no longer applied to FormattedStrings.

Please see this thread on Discord.

Reproduction

iOS + Angular
Use the following in a modal component html:

<Label>
    <FormattedString>
      <Span [text]="Test string:"> </Span>
      <Span
        [style]="color: rgb(40, 158, 191)"
        [text]="[email protected]"
      ></Span>
    </FormattedString>
  </Label>

Create the modal with both NativeDialogService and ModalDialogService. Observe that the modal created with the deprecated ModalDialogService displays the FormattedString with color appropriately, but the one displayed with the new NativeDialogService does not apply the color style

ModalDialogService:
Screenshot 2023-10-25 at 3 10 02 PM

NativeDialogService:
Screenshot 2023-10-25 at 3 10 15 PM

Relevant log output (if applicable)

No response

Environment

OS: macOS 14.0
CPU: (12) arm64 Apple M2 Pro
Shell: /bin/zsh
node: 20.4.0
npm: 9.7.2
nativescript: 8.5.3

# android
java: 12.0.2
ndk: Not Found
apis: Not Found
build_tools: Not Found
system_images: Not Found

# ios
xcode: 15.0.1/15A507
cocoapods: 1.13.0
python: Not Found
python3: 3.9.6
ruby: 2.7.8
platforms:
  - DriverKit 23.0
  - iOS 17.0
  - macOS 14.0
  - tvOS 17.0
  - watchOS 10.0

Dependencies

"dependencies": {
  "@angular/animations": "~16.2.9",
  "@angular/common": "~16.2.9",
  "@angular/compiler": "~16.2.9",
  "@angular/core": "~16.2.9",
  "@angular/forms": "~16.2.9",
  "@angular/platform-browser": "~16.2.9",
  "@angular/router": "~16.2.9",
  "@apollo/client": "^3.7.16",
  "@faker-js/faker": "^8.1.0",
  "@nativescript-community/ui-material-bottomsheet": "^7.1.3",
  "@nativescript-community/ui-material-core": "^7.1.3",
  "@nativescript-community/ui-material-snackbar": "^7.1.3",
  "@nativescript-community/ui-material-tabs": "^7.1.3",
  "@nativescript/angular": "~16.0.0",
  "@nativescript/background-http": "^6.0.0",
  "@nativescript/core": "^8.5.7",
  "@nativescript/firebase-analytics": "^3.1.2",
  "@nativescript/firebase-core": "^3.1.2",
  "@nativescript/firebase-crashlytics": "^3.1.2",
  "@nativescript/imagepicker": "^2.0.2",
  "@nativescript/iqkeyboardmanager": "^2.1.1",
  "@nativescript/localize": "^5.1.0",
  "@nativescript/secure-storage": "^3.0.2",
  "@nativescript/theme": "^3.0.2",
  "@nativescript/unit-test-runner": "^3.0.4",
  "@nativescript/zone-js": "^3.0.4",
  "@ngtools/webpack": "^16.2.6",
  "@ngxs/form-plugin": "^3.8.1",
  "@ngxs/store": "^3.8.1",
  "@nstudio/nativescript-cardview": "^2.0.2",
  "@nstudio/nativescript-checkbox": "^2.0.4",
  "apollo-angular": "^5.0.0",
  "classnames": "^2.3.1",
  "graphql": "^16.7.1",
  "lodash-es": "^4.17.21",
  "moment": "^2.29.4",
  "nativescript-clipboard": "^2.1.1",
  "nativescript-dna-deviceinfo": "^3.7.3",
  "nativescript-exit": "^1.0.1",
  "nativescript-modal-datetimepicker": "^2.1.5",
  "nativescript-oauth2": "^3.0.10",
  "nativescript-phone": "^3.0.3",
  "nativescript-ui-sidedrawer": "^15.2.0",
  "ngxs-reset-plugin": "^3.0.0",
  "rosie": "^2.1.0",
  "rxjs": "^7.8.1",
  "semver": "^7.5.4",
  "zone.js": "^0.13.3"
},
"devDependencies": {
  "@angular-devkit/build-angular": "^16.2.6",
  "@nativescript/android": "^8.6.2",
  "@nativescript/ios": "^8.5.2",
  "@nativescript/types": "~8.6.1",
  "@nativescript/webpack": "~5.0.16",
  "@types/chai": "^4.3.5",
  "@types/jasmine": "^5.1.0",
  "@types/jasminewd2": "^2.0.10",
  "@types/lodash-es": "^4.17.6",
  "@types/node": "^20.4.1",
  "@types/rosie": "^0.0.43",
  "@typescript-eslint/eslint-plugin": "^6.7.5",
  "@typescript-eslint/parser": "^6.7.5",
  "babel-traverse": "6.26.0",
  "babel-types": "6.26.0",
  "babylon": "6.18.0",
  "eslint": "^8.44.0",
  "eslint-config-prettier": "^9.0.0",
  "eslint-import-resolver-typescript": "^3.5.3",
  "eslint-plugin-import": "^2.27.5",
  "eslint-plugin-prettier": "^5.0.0",
  "husky": "^8.0.3",
  "karma": "^6.4.0",
  "karma-jasmine": "^4.0.2",
  "karma-nativescript-launcher": "^0.4.0",
  "karma-webpack": "~5.0.0",
  "lazy": "1.0.11",
  "lint-staged": "^14.0.1",
  "npm-run-all": "^4.1.5",
  "prettier": "^3.0.0",
  "sass": "^1.63.6",
  "stylelint": "^15.10.1",
  "stylelint-config-standard": "^34.0.0",
  "stylelint-config-standard-scss": "^11.0.0",
  "stylelint-scss": "^5.0.1",
  "ts-node": "^10.7.0",
  "ts-patch": "^3.0.1",
  "tsconfig-paths": "^4.1.2",
  "typescript": "^5.1.6",
  "typescript-strict-plugin": "^2.1.0"
}

Please accept these terms

@CodeWitchJosie CodeWitchJosie added the bug-pending-triage Reported bug, pending triage to confirm. label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-pending-triage Reported bug, pending triage to confirm.
Projects
None yet
Development

No branches or pull requests

1 participant