Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to change render target #14

Open
adamplayer opened this issue May 1, 2023 · 2 comments
Open

Add ability to change render target #14

adamplayer opened this issue May 1, 2023 · 2 comments
Labels

Comments

@adamplayer
Copy link

Some games might use a different render target besides the hardcoded one here

// We only look at RT 0 currently. const uint32_t kRenderTargetIndex = 0;

Could this be either an option set in the rtx.conf file or even added to the imgui interface?

@anchorlightforge
Copy link
Contributor

I've added an imgui option for testing on my own fork: https://github.com/anchorlightforge/dxvk-remix/releases/tag/RenderTargetImgui

For titles that use multiple render targets this won't be enough to fix the issue unfortunately.

svc-remix-github pushed a commit that referenced this issue Aug 15, 2023
Added Split Texture GUI (#14)

* dxvk_imgui.cpp - Lightmap/Hide Instance in UI

Added some hidden features to the UI, with a commented-out line for World Space UI Background.

* Description revision, offset drag in texture GUI

Revised the description for World Space Background UI Textures and added the drag float to the split texture GUI, similar to how the legacy cutout texture GUI previously was handled.

* Fix description for worldSpaceUIBackgroundTexture

* Imgui texture interface Rev. 2 (#12)

Incorporated several changes based on the feedback provided in #30 :

    Added an Unindent to every Split Texture category to fully utilize the space
    Corrected some improper min/max bounds on new sliders
    Added scaling float and slider for texture selection thumbnails
    Added indent for clarity in Split Texture List view

* Fix Bounds on Background Offset DragFloat

Quick but significant fix allowing for negative values on World Space UI Background Offset in GUI.

* Incorporate code review

rtxoptions.h:
- Removed redundant getter to use direct value of textureGridThumbnailScale

dxvk_imgui.cpp:
- Preserved intended separation between Unique Object Search Distance and Vertex Color Strength
- Removed additional sliders from Legacy GUI (Force Cutout Alpha is now included in the main GUI's Texture Parameters category)
- Added comment explaining Unindent/Indent workaround applied to legacy GUI

dxvk_imgui_about.cpp:
- Added to Github Contributors credits

#30 (review)

Additional commits (squashed): Restored an option lost to rebase merge conflicts.
@NV-DM
Copy link
Collaborator

NV-DM commented Nov 1, 2023

This is tracked by REMIX-1205

@NV-DM NV-DM added the jira label Nov 1, 2023
svc-remix-github pushed a commit that referenced this issue Apr 17, 2024
Added Split Texture GUI (#14)

* dxvk_imgui.cpp - Lightmap/Hide Instance in UI

Added some hidden features to the UI, with a commented-out line for World Space UI Background.

* Description revision, offset drag in texture GUI

Revised the description for World Space Background UI Textures and added the drag float to the split texture GUI, similar to how the legacy cutout texture GUI previously was handled.

* Fix description for worldSpaceUIBackgroundTexture

* Imgui texture interface Rev. 2 (#12)

Incorporated several changes based on the feedback provided in #30 :

    Added an Unindent to every Split Texture category to fully utilize the space
    Corrected some improper min/max bounds on new sliders
    Added scaling float and slider for texture selection thumbnails
    Added indent for clarity in Split Texture List view

* Fix Bounds on Background Offset DragFloat

Quick but significant fix allowing for negative values on World Space UI Background Offset in GUI.

* Incorporate code review

rtxoptions.h:
- Removed redundant getter to use direct value of textureGridThumbnailScale

dxvk_imgui.cpp:
- Preserved intended separation between Unique Object Search Distance and Vertex Color Strength
- Removed additional sliders from Legacy GUI (Force Cutout Alpha is now included in the main GUI's Texture Parameters category)
- Added comment explaining Unindent/Indent workaround applied to legacy GUI

dxvk_imgui_about.cpp:
- Added to Github Contributors credits

#30 (review)

Additional commits (squashed): Restored an option lost to rebase merge conflicts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants