Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Planar joint in parse_urdf is not passed all arguments #454

Open
jc211 opened this issue Jan 24, 2025 · 1 comment
Open

[BUG] Planar joint in parse_urdf is not passed all arguments #454

jc211 opened this issue Jan 24, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@jc211
Copy link

jc211 commented Jan 24, 2025

Bug Description

Hi, planar joints are missing the mode, target_kd, and target_ke keywords and as a result they are not being set to position mode when asked to be. These just need to be passed in to JointAxis

u, limit_lower=lower * scale, limit_upper=upper * scale, limit_ke=limit_ke, limit_kd=limit_kd

These should be:

                linear_axes=[
                    wp.sim.JointAxis(
                        u,
                        limit_lower=lower * scale,
                        limit_upper=upper * scale,
                        limit_ke=limit_ke,
                        limit_kd=limit_kd,
                        target_ke=stiffness,
                        target_kd=joint_damping,
                        mode=joint_mode,
                    ),
                    wp.sim.JointAxis(
                        v,
                        limit_lower=lower * scale,
                        limit_upper=upper * scale,
                        limit_ke=limit_ke,
                        limit_kd=limit_kd,
                        target_ke=stiffness,
                        target_kd=joint_damping,
                        mode=joint_mode,
                    ),
                ],

System Information

No response

@jc211 jc211 added the bug Something isn't working label Jan 24, 2025
@jc211
Copy link
Author

jc211 commented Jan 24, 2025

Actually, something is still wrong here - its off by a factor of 2 - I didn't track why this is the case and instead just used two prismatic joints to simulate a planar one. That works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants