Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrating Sym with Core: Network Architecture Layers #62

Merged
merged 15 commits into from
Sep 29, 2023
Merged

Integrating Sym with Core: Network Architecture Layers #62

merged 15 commits into from
Sep 29, 2023

Conversation

mnabian
Copy link
Collaborator

@mnabian mnabian commented Sep 20, 2023 •
edited by NickGeneva
Loading

Modulus Pull Request

Description

Closes #64

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

@mnabian mnabian self-assigned this Sep 20, 2023
@mnabian mnabian added the 2 - In Progress Currently a work in progress label Sep 20, 2023
@mnabian mnabian changed the title Integrating Sym with Core: Models Integrating Sym with Core: Network Architecture Layers Sep 21, 2023
@mnabian
Copy link
Collaborator Author

mnabian commented Sep 21, 2023

/blossom-ci

@mnabian mnabian added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Sep 21, 2023
@mnabian mnabian linked an issue Sep 21, 2023 that may be closed by this pull request
🚀[FEA]: Integrate the network architecture layers in Sym with Core #64
Closed
@loliverhennigh
Copy link
Collaborator

We can pull over sym.models.activation to core as well but maybe we can make that a separate PR and leave it for the future unless you think its easy to do now.

@mnabian
Copy link
Collaborator Author

mnabian commented Sep 21, 2023

We can pull over sym.models.activation to core as well but maybe we can make that a separate PR and leave it for the future unless you think its easy to do now.

@loliverhennigh it requires some refactoring, as we already have some activations in core: https://github.com/NVIDIA/modulus/blob/main/modulus/models/layers/activations.py
Let us track this in a separate PR.

@mnabian
Copy link
Collaborator Author

mnabian commented Sep 28, 2023

/blossom-ci

@mnabian
Copy link
Collaborator Author

mnabian commented Sep 28, 2023

/blossom-ci

1 similar comment
@mnabian
Copy link
Collaborator Author

mnabian commented Sep 28, 2023

/blossom-ci

@mnabian
Copy link
Collaborator Author

mnabian commented Sep 28, 2023

/blossom-ci

@mnabian mnabian merged commit 85c46c3 into NVIDIA:main Sep 29, 2023
@mnabian mnabian deleted the fea_ext_integration branch September 29, 2023 00:07
@ktangsali ktangsali mentioned this pull request Dec 19, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktangsali ktangsali ktangsali approved these changes

@loliverhennigh loliverhennigh loliverhennigh approved these changes

Assignees

@mnabian mnabian

Labels
3 - Ready for Review Ready for review by team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀[FEA]: Integrate the network architecture layers in Sym with Core
3 participants
@mnabian @loliverhennigh @ktangsali