Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove global newDynamicLibrary function and replace with embedded one #110

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Remove global newDynamicLibrary function and replace with embedded one #110

merged 1 commit into from
Apr 3, 2024

Conversation

klueska
Copy link
Contributor

@klueska klueska commented Apr 3, 2024

No description provided.

@klueska klueska requested a review from elezar April 3, 2024 19:46
elezar
elezar approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment. Feel free to merge if it isn'tn relevant though.

pkg/nvml/lib.go Show resolved Hide resolved
@klueska klueska merged commit 5362631 into NVIDIA:main Apr 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elezar elezar elezar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klueska @elezar