Move development directly into pkg/nvml instead of gen/nvml #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Klues <[email protected]>
This removes the following warning during build: docker: [DEPRECATION NOTICE] Docker Image Format v1 and Docker Image manifest version 2, schema 1 support is disabled by default and will be removed in an upcoming release. Suggest the author of docker.io/stedolan/jq:latest to upgrade the image to the OCI Format or Docker Image manifest v2, schema 2. More information at https://docs.docker.com/go/deprecated-image-specs/. Signed-off-by: Kevin Klues <[email protected]>
Signed-off-by: Kevin Klues <[email protected]>
Going forward, development will happen directly in pkg/nvml Signed-off-by: Kevin Klues <[email protected]>
Signed-off-by: Kevin Klues <[email protected]>
Signed-off-by: Kevin Klues <[email protected]>
elezar
approved these changes
Apr 3, 2024
| @@ -139,12 +139,11 @@ bindings: .create-bindings .strip-autogen-comment .strip-nvml-h-linenumber | |||
| .create-bindings: $(PKG_BINDINGS_DIR)/nvml.h $(SOURCES) | $(PKG_BINDINGS_DIR) | |||
| cp $(GEN_BINDINGS_DIR)/nvml.yml $(PKG_BINDINGS_DIR) | |||
| c-for-go -out $(PKG_DIR) $(PKG_BINDINGS_DIR)/nvml.yml | |||
There was a problem hiding this comment.
Question: Instead of copying the yml file in the previous step, could we specify $(GEN_BINDINGS_DIR)/nvml.yml as input here? Then we also wouldn't need to remove it later?
There was a problem hiding this comment.
When I do that I get an incorrect pkg/types_gen.so file that gets generated. It's unclear why this is the case, but the fact that it doesn't "just work" when simplifying this means that it likely warrants a new PR to investigate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #97
Closes: #98