Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move C.RTLD_DEEPBIND do linux-specific file #73

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

elezar
Copy link
Member

@elezar elezar commented Aug 11, 2023

This change ensures that the dl package works on Darwin platforms where C.RTLD_DEEPBIND is not defined.

Before this change:

➜  go-nvml git:(main) ✗ go build ./pkg/dl/...
# github.com/NVIDIA/go-nvml/pkg/dl
pkg/dl/dl.go:36:18: could not determine kind of name for C.RTLD_DEEPBIND
➜  go-nvml git:(main) ✗ echo $?
1

After this change:

➜  go-nvml git:(fix-deepbind) ✗ go build ./pkg/dl/...
➜  go-nvml git:(fix-deepbind) ✗ echo $?
0
```

@elezar elezar requested a review from klueska August 11, 2023 14:59
@elezar elezar self-assigned this Aug 11, 2023
@elezar
Copy link
Member Author

elezar commented Aug 25, 2023

/blossom-ci

1 similar comment
@elezar
Copy link
Member Author

elezar commented Sep 19, 2023

/blossom-ci

@elezar
Copy link
Member Author

elezar commented Sep 19, 2023

/blossom-ci

1 similar comment
@elezar
Copy link
Member Author

elezar commented Sep 19, 2023

/blossom-ci

@elezar elezar merged commit feedc62 into NVIDIA:main Oct 12, 2023
1 check passed
@elezar elezar deleted the fix-deepbind branch October 12, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant