Add option to configure SHA256 hash algorithm instead of MD5 #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closing as I need to re-create the change with signed commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment, the library by default uses MD5 hashing and does not allow the option to choose an alternative algorithm from the approved list under FIPS regulation. Some versions of Python, which are FIPS compliant, will raise an error when trying to use the MD5 hashing algorithm (more information on FIPS specific behaviour in python docs).
This change-set preserves the current default (MD5) but allows choosing SHA-256 as an alternative.
Related Issue(s)
Checklist