Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for general dimension names in make_regional_mosaic #173

Open
uramirez8707 opened this issue Jul 28, 2022 · 1 comment
Open

Allow for general dimension names in make_regional_mosaic #173

uramirez8707 opened this issue Jul 28, 2022 · 1 comment

Comments

@uramirez8707
Copy link
Contributor

Is your feature request related to a problem? Please describe.
If you have a diag_table with multiple regions you end up with files with different dimensions names than what make_regional_mosaic expects. For example:

"test_regional",         1, "hours",   1, "hours", "time"                                                              
"test_regional2",         1, "hours",   1, "hours", "time"                                                          
                                                                                                                       
#output variables                                                                                                      
 "test_diag_manager_mod", "sst", "sst", "test_regional",  "all", ".true." "10 30 20 40 -1 -1", 2                        
 "test_diag_manager_mod", "sst", "sst", "test_regional2",  "all", ".true." "5 10 20 40 -1 -1", 2

This will result in:
netcdf test_regional.nc {
dimensions:
x_sub01 = 21 ;
y_sub01 = 10 ;

netcdf test_regional2 {
dimensions:
x_sub02 = 6 ;
y_sub02 = 10 ;

make_regional_mosaic expects the dimension name to be have sub01 so make_regional_mosaic will fail for the second file.

See helpdesk ticket #5021146 for more info.

Describe the solution you'd like
Can make_regional_mosaic be modified to accept any dimension name?

Describe alternatives you've considered
Manually change the dimension name before calling make_regional_mosaic
Change this at the diag_manager level.

Additional context
N/A

@ngs333
Copy link
Contributor

ngs333 commented Aug 10, 2022

@uramirez8707
The consensus at the workflow meeting on 8/4 was to not update make-regional-mosiac at this time. This issue (or a related issue) will likely be looked at in the future since it was noted at the meeting that there should be a wider discussion on future grid needs in the workflow that NCTools will have to support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants