Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default colors for console target to highligt errors in red #5388

Open
snakefoot opened this issue Oct 29, 2023 · 1 comment
Open
Labels
console-target new default (breaking) Kind of Breaking behavior change
Milestone

Comments

@snakefoot
Copy link
Contributor

snakefoot commented Oct 29, 2023

These are the colors used by NLog ColoredConsole:

            new ConsoleRowHighlightingRule("level == LogLevel.Fatal", ConsoleOutputColor.Red, ConsoleOutputColor.NoChange),
            new ConsoleRowHighlightingRule("level == LogLevel.Error", ConsoleOutputColor.Yellow, ConsoleOutputColor.NoChange),
            new ConsoleRowHighlightingRule("level == LogLevel.Warn", ConsoleOutputColor.Magenta, ConsoleOutputColor.NoChange),

The standard is usually red-for-error and yellow-for-warning. NLog should follow the standard, and just use Red-color for both Fatal and Error and yellow-color for Warn (Not Magenta)

image

@snakefoot snakefoot added this to the 6.0 milestone Oct 29, 2023
@welcome
Copy link

welcome bot commented Oct 29, 2023

Hi! Thanks for opening your first issue here! Please make sure to follow the issue template - so we could help you better!

@snakefoot snakefoot added console-target new default (breaking) Kind of Breaking behavior change labels Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
console-target new default (breaking) Kind of Breaking behavior change
Projects
None yet
Development

No branches or pull requests

1 participant