Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SimpleLayout to be immutable #5225

Open
snakefoot opened this issue May 21, 2023 · 1 comment
Open

Change SimpleLayout to be immutable #5225

snakefoot opened this issue May 21, 2023 · 1 comment
Labels
breaking change Breaking API change (different to semantic change)
Milestone

Comments

@snakefoot
Copy link
Contributor

snakefoot commented May 21, 2023

Remove the Text-property-setter, and the ConfigurationItemFactory-instance-field.

This will allow one to create SimpleLayout without involving the ConfigurationItemFactory.

Introduce fluent-api for creating SimpleLayout from chain of layoutrenderers (skip parsing and reflection-logic)

@snakefoot snakefoot added the breaking change Breaking API change (different to semantic change) label May 21, 2023
@snakefoot snakefoot added this to the 6.0 milestone May 21, 2023
@snakefoot
Copy link
Contributor Author

snakefoot commented Jul 20, 2023

Notice there is a hurdle with handling dynamic assignment of text-property:

    <layout xsi:type="LayoutWithHeaderAndFooter">
        <header xsi:type="SimpleLayout" text="&lt;?xml version=&quot;1.0&quot; encoding=&quot;utf-8&quot; ?&gt;&lt;root xmlns:log4j=&quot;http://jakarta.apache.org/log4j/&quot;&gt;"/>
        <layout xsi:type="Log4JXmlEventLayout" />
        <footer xsi:type="SimpleLayout" text="&lt;/root&gt;"/>
    </layout>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Breaking API change (different to semantic change)
Projects
None yet
Development

No branches or pull requests

1 participant