binary_search_tree.py: Add BST data structure #122

gabrieldluca · 2018-10-01T14:49:16Z

This adds Binary Search Tree algorithm which keeps values in sorted
order, so that lookup and other operations can use the principles of
binary search while traversing the tree from root to leaf.

Closes #51

By submitting this pull request I confirm I've read and complied with the
below declarations.

I have read the Contribution guidelines and I am confident that my PR reflects them.
I have followed the commit guidelines for this project.
My code follows the standard code structure.
This pull request has a descriptive title. For example, {Tag}: Add {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.
This pull request shall only be reviewed and merged once all the checks passes. No maintainer or supporter shall be obliged to review it before this condition is met.
I have mentioned the issue number correctly (with hyperlink) in this pull request description.

After you submit your pull request, DO NOT click the 'Update Branch' button.

gabrieldluca · 2018-10-01T22:04:17Z

@sangamcse Please review.

sangamcse · 2018-10-01T22:06:32Z

@sangamcse rebase

sangamcse · 2018-10-01T22:06:34Z

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

sangamcse · 2018-10-01T22:07:25Z

Automated rebase with GitMate.io was successful! 🎉

sangamcse · 2018-10-01T22:09:25Z

Update in Readme and code comments needed.

sangamcse · 2018-10-01T22:10:30Z

binary_search_tree/Python/binary_search_tree.py

+ """
+ Class that represent a leaf node of a binary tree.
+ """
+


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpikx6la4g/binary_search_tree/Python/binary_search_tree.py +++ b/tmp/tmpikx6la4g/binary_search_tree/Python/binary_search_tree.py @@ -2,7 +2,7 @@ """ Class that represent a leaf node of a binary tree. """ - + def __init__(self, value=None, leftChild=None, rightChild=None): self.value = value self.leftChild = leftChild

sangamcse · 2018-10-01T22:10:30Z

binary_search_tree/Python/binary_search_tree.py

+ Class that represents a Binary Search Tree
+ <https://en.wikipedia.org/wiki/Binary_search_tree>.
+ """
+


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpikx6la4g/binary_search_tree/Python/binary_search_tree.py +++ b/tmp/tmpikx6la4g/binary_search_tree/Python/binary_search_tree.py @@ -27,7 +27,7 @@ Class that represents a Binary Search Tree <https://en.wikipedia.org/wiki/Binary_search_tree>. """ - + def __init__(self): self.root = None

sangamcse · 2018-10-01T22:10:31Z

binary_search_tree/Python/binary_search_tree.py

+
+ def __init__(self):
+ self.root = None
+


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpikx6la4g/binary_search_tree/Python/binary_search_tree.py +++ b/tmp/tmpikx6la4g/binary_search_tree/Python/binary_search_tree.py @@ -30,7 +30,7 @@ def __init__(self): self.root = None - + def __del__(self): del self.root

sangamcse · 2018-10-01T22:10:32Z

binary_search_tree/Python/binary_search_tree.py

+ else:
+ currentNode.value = value
+ return currentNode
+


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpikx6la4g/binary_search_tree/Python/binary_search_tree.py +++ b/tmp/tmpikx6la4g/binary_search_tree/Python/binary_search_tree.py @@ -60,7 +60,7 @@ else: currentNode.value = value return currentNode - + def main(): values = [1, 2, 0, 1.5, 0.5] tree = BST()

gabrieldluca · 2018-10-02T01:51:53Z

@sangamcse I've updated the code problems and updated the README file. Please check again once you're ready.

sangamcse · 2018-10-02T08:31:07Z

@sangamcse rebase

sangamcse · 2018-10-02T08:31:10Z

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

sangamcse · 2018-10-02T08:35:04Z

@gabrieldluca, I tried rebasing your repo but it failed. Kindly rebase it locally and push it again on success.

gabrieldluca · 2018-10-03T17:35:01Z

@sangamcse Done!

sangamcse · 2018-10-03T17:46:41Z

@sangamcse rebase

sangamcse · 2018-10-03T17:46:43Z

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

This adds Binary Search Tree data structure which keeps values in sorted order, so that lookup and other operations can use the principles of binary search while traversing the tree from root to leaf. Closes #51

sangamcse · 2018-10-03T17:47:33Z

Automated rebase with GitMate.io was successful! 🎉

sangamcse · 2018-10-04T06:16:59Z

@sangamcse rebase

sangamcse · 2018-10-04T06:17:01Z

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

sangamcse · 2018-10-04T06:18:32Z

Automated rebase failed! Please rebase your pull request manually via the command line.

Reason:

Command: git rebase base/master

Exit Code: 128

Cause:

.git/rebase-apply/patch:20: trailing whitespace.
class Leaf:
.git/rebase-apply/patch:21: trailing whitespace.
    """
.git/rebase-apply/patch:22: trailing whitespace.
    Class that represent a leaf node of a binary tree.
.git/rebase-apply/patch:23: trailing whitespace.
    """
.git/rebase-apply/patch:24: trailing whitespace.

warning: squelched 74 whitespace errors
warning: 79 lines add whitespace errors.
error: Failed to merge in the changes.

sangamcse · 2018-10-04T06:20:15Z

@gabrieldluca the PR is approved but we need to rebase it before merging it. So rebase it manually and remind me on gitter once it is done https://gitter.im/NITSkmOS/algo

Note: Do not open any PR to any organization from the master branch because it makes difficult to maintain the PR.

sangamcse added process/pending_review difficulty/low hacktoberfest HACKTOBERFEST 2020 lang/Python type/data structure labels Oct 1, 2018

gabrieldluca changed the title ~~binary_search_tree.py: Add BST algorithm [Python]~~ binary_search_tree.py: Add BST data structure [Python] Oct 1, 2018

sangamcse reviewed Oct 1, 2018

View reviewed changes

sangamcse assigned gabrieldluca Oct 2, 2018

sangamcse added process/wip Work in Progress process/pending_review and removed process/pending_review labels Oct 2, 2018

sangamcse changed the title ~~binary_search_tree.py: Add BST data structure [Python]~~ binary_search_tree.py: Add BST data structure Oct 3, 2018

sangamcse added process/approved and removed process/wip Work in Progress process/pending_review labels Oct 3, 2018

Gabriel D'Luca and others added 3 commits October 3, 2018 17:47

binary_search_tree.py: Add BST data structure

7ddfde6

This adds Binary Search Tree data structure which keeps values in sorted order, so that lookup and other operations can use the principles of binary search while traversing the tree from root to leaf. Closes #51

Update README.md

c2e8f67

Update README.md

171c359

sangamcse added the process/pending_review label Oct 3, 2018

sangamcse removed the process/pending_review label Oct 4, 2018

gabrieldluca closed this Oct 8, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

binary_search_tree.py: Add BST data structure #122

binary_search_tree.py: Add BST data structure #122

gabrieldluca commented Oct 1, 2018

gabrieldluca commented Oct 1, 2018

sangamcse commented Oct 1, 2018

sangamcse commented Oct 1, 2018

sangamcse commented Oct 1, 2018

sangamcse commented Oct 1, 2018

sangamcse Oct 1, 2018

sangamcse Oct 1, 2018

sangamcse Oct 1, 2018

sangamcse Oct 1, 2018

gabrieldluca commented Oct 2, 2018

sangamcse commented Oct 2, 2018

sangamcse commented Oct 2, 2018

sangamcse commented Oct 2, 2018

gabrieldluca commented Oct 3, 2018

sangamcse commented Oct 3, 2018

sangamcse commented Oct 3, 2018

sangamcse commented Oct 3, 2018

sangamcse commented Oct 4, 2018

sangamcse commented Oct 4, 2018

sangamcse commented Oct 4, 2018

sangamcse commented Oct 4, 2018 •

edited

binary_search_tree.py: Add BST data structure #122

binary_search_tree.py: Add BST data structure #122

Conversation

gabrieldluca commented Oct 1, 2018

gabrieldluca commented Oct 1, 2018

sangamcse commented Oct 1, 2018

sangamcse commented Oct 1, 2018

sangamcse commented Oct 1, 2018

sangamcse commented Oct 1, 2018

sangamcse Oct 1, 2018

Choose a reason for hiding this comment

sangamcse Oct 1, 2018

Choose a reason for hiding this comment

sangamcse Oct 1, 2018

Choose a reason for hiding this comment

sangamcse Oct 1, 2018

Choose a reason for hiding this comment

gabrieldluca commented Oct 2, 2018

sangamcse commented Oct 2, 2018

sangamcse commented Oct 2, 2018

sangamcse commented Oct 2, 2018

gabrieldluca commented Oct 3, 2018

sangamcse commented Oct 3, 2018

sangamcse commented Oct 3, 2018

sangamcse commented Oct 3, 2018

sangamcse commented Oct 4, 2018

sangamcse commented Oct 4, 2018

sangamcse commented Oct 4, 2018

sangamcse commented Oct 4, 2018 • edited

sangamcse commented Oct 4, 2018 •

edited