Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy Environment Variables are Case-Sensitive #182

Open
ld-carapace opened this issue Dec 3, 2024 · 1 comment
Open

Proxy Environment Variables are Case-Sensitive #182

ld-carapace opened this issue Dec 3, 2024 · 1 comment
Assignees
Labels
bug Something isn't working needs testing (on unstable) A feature that now exists, but is looking for people to test and use it

Comments

@ld-carapace
Copy link

When RSSH tries to auto-detect proxy config from the environment variables, it looks for os.Getenv("http_proxy"). This is a case-sensitive operation.

This means if the environment variable is instead uppercase HTTP_PROXY, it will not detect it.

I would suggest 2 potential fixes:

  • Try looking up both http_proxy and HTTP_PROXY, or;
  • Manually parse the environment variables, looking for a case-invariant match of http_proxy.
@NHAS NHAS self-assigned this Dec 3, 2024
@NHAS NHAS added the bug Something isn't working label Dec 3, 2024
NHAS added a commit that referenced this issue Dec 3, 2024
@NHAS NHAS added enhancement New feature or request needs testing (on unstable) A feature that now exists, but is looking for people to test and use it and removed enhancement New feature or request labels Dec 3, 2024
@NHAS
Copy link
Owner

NHAS commented Dec 3, 2024

This is now on unstable, its a fairly significant change to the environment variable handlers, so please test to see if it works properly.

Then I'll do a release, as this work also incorporates the windows kerberos proxy work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs testing (on unstable) A feature that now exists, but is looking for people to test and use it
Projects
None yet
Development

No branches or pull requests

2 participants