Skip to content
This repository has been archived by the owner on Apr 30, 2021. It is now read-only.

significance tests #89

Open
matt-long opened this issue Mar 9, 2019 · 3 comments
Open

significance tests #89

matt-long opened this issue Mar 9, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@matt-long
Copy link
Contributor

For our statistics functions, like weighted_cor it would be nice to enable computing significance metrics (p-value...).

@bradyrx, perhaps you can help with this?

@bradyrx
Copy link
Contributor

bradyrx commented Mar 9, 2019

@matt-long, yes I'd be happy to open a PR on this. Are you trying to keep esmlab slim on dependencies?

xskillscore has a pearson_r_p_value function that is based in numpy and written as an xarray ufunc. Although this only allows a two-tailed test.

I can also port over some functions from climpred (https://github.com/bradyrx/climpred/blob/master/climpred/stats.py) which accounts for autocorrelation in the time series by computing the effective sample size (Bretherton et al. 1999).

@matt-long
Copy link
Contributor Author

I am fine with dependencies as long as they are good ones.

@bradyrx
Copy link
Contributor

bradyrx commented Mar 28, 2019

Implemented in #90, although should stay open until effective sample size is incorporated (will get on this when time allows).

@andersy005 andersy005 added enhancement New feature or request and removed feature labels Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants