Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PolarCoordConverter Logic error #160

Open
christopherpicard opened this issue Nov 3, 2018 · 2 comments
Open

PolarCoordConverter Logic error #160

christopherpicard opened this issue Nov 3, 2018 · 2 comments

Comments

@christopherpicard
Copy link

There is a logic error in the PolarCoordConverter. The else block on line 325 should have curly brace around lines 326 and 327. Currently written line 327 is executed regardless of the southern hemisphere flag. This results in an incorrect northing value when in the northern hemisphere.

@christopherpicard christopherpicard changed the title PlarCoordConverter Logic error PolarCoordConverter Logic error Nov 3, 2018
@gbburkhardt
Copy link
Contributor

Actually, since the variable 'Southern_Hemisphere' is non-zero for negative latitudes, it's the northing for southern hemisphere values that's incorrect.

Thank you very much for noting this.

@gbburkhardt
Copy link
Contributor

See also:
#157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants