Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding custom browsers via config file doesn't work #31

Open
phiberr opened this issue Mar 8, 2024 · 2 comments
Open

Adding custom browsers via config file doesn't work #31

phiberr opened this issue Mar 8, 2024 · 2 comments

Comments

@phiberr
Copy link

phiberr commented Mar 8, 2024

I believe there was a change in the code to no longer use the installed_browsers config
browser_count=$((browser_count+1))
installed_browsers[$browser_count]="Browser Name : path/to/browser -args"

I've ensured I'm using the tab char before and after the :

Perhaps a change was made that isn't backwards compatible?

@phiberr
Copy link
Author

phiberr commented Mar 11, 2024

Here's an example config that works with the [v0.9 (alpha)] release for anyone running into this.

browser_count=$((browser_count+1))
BROWSER_LIST[$browser_count]="ffdefault"
BROWSER_NAME[ffdefault]="FireFox Default"
BROWSER_PATH[ffdefault]=$(which firefox)
BROWSER_ARGS[ffdefault]="-P Default"
browser_count=$((browser_count+1))
BROWSER_LIST[$browser_count]="ff2"
BROWSER_NAME[ff2]="FireFox Profile2"
BROWSER_PATH[ff2]=$(which firefox)
BROWSER_ARGS[ff2]="-P Profile2"
browser_count=$((browser_count+1))
BROWSER_LIST[$browser_count]="ff3"
BROWSER_NAME[ff3]="FireFox Profile3"
BROWSER_PATH[ff3]=$(which firefox)
BROWSER_ARGS[ff3]="-P Profile3"

@odnar-dev
Copy link
Member

sorry i forget to implement backward compatibility in this update,and didn't have time to update the documentation/wiki

you can also use the add_browser function in your config file

# use: add_browser $browser_id $browser_name $browser_path $browser_args
add_browser "ffdefault" "FireFox Default" "$(which firefox)" "-P Default"
add_browser "ff2" "FireFox Profile 2" "$(which firefox)" "-P Profile2"
add_browser "ff3" "FireFox Profile 3" "$(which firefox)" "-P Profile3"

@odnar-dev odnar-dev pinned this issue Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants