Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing a "per host colors" item or changing "Regexp" may link to color to other per host settings instead of reverting to default. #18

Open
Adaephon-GH opened this issue Feb 11, 2021 · 0 comments

Comments

@Adaephon-GH
Copy link

After removing a host setting from the "per host colors" list, I noticed that the color of the tabs of the removed host (at least sometimes) do not revert to the default color selection. Instead it seems to become linked to another per host setting, even if the name/regex should not match at all.

For example:

Here I have a bunch of per host settings, although none that would match either github.com or bitbucket.org (I apologize for the garish color selection, but I wanted to ensure that the difference is obvious. Also every screenshot shows the state of things immediately after pressing "Save and apply settings"):
tst_colored_tabs_1
Then I first added and saved a setting for github.com:
tst_colored_tabs_2
After that a different color for bitbucket.org:
tst_colored_tabs_3
So far everything seemed to work just as intended.

The surprise came when removing the setting for github.com again. Now the tab had the same color as the one I chose for bitbucket.org:
tst_colored_tabs_4
To confirm that it is not just coincidence (although the chosen Lightness setting should not even allow for that color to be chosen automatically) I changed the color for bitbucket.org, which also applied the change to the github.com tab:
tst_colored_tabs_5
Only after also removing the setting for bitbucket.com things seemed to be back to normal:
tst_colored_tabs_6
"Seemed to" because after adding a per host setting with an (by accident) empty "Host" field, bitbucket.org, github.com as well as the the browser specific pages about:addons and about:newtab were linked to the same color:
tst_colored_tabs_7
This link also remained after correcting the empty text to "github.com"
tst_colored_tabs_8

Similar things also happen, when the "Regexp" checkbox is toggled for an item. Here I have several Regexp settings, all working as intended:
tst_colored_tabs_9
After disabling the Regexp checkbox on one setting (in this case the one that matches firefox extension pages, i.e. moz-extension://…), these tabs revert to another regexp enabled host (in this case .*\.?stackexchange\.com
tst_colored_tabs_10

It looks like the settings will only work as intended after restarting the browser. Just disabling/re-enabling TST Colored Tabs or even Tree Style Tabs is not enough. While this makes the issue less serious, it nevertheless may complicate setting up a colorscheme, especially when experimenting with regexp. (I initially found this issue when I had a regexp that was subtly wrong, but initially seemed to work because I previously had non-regexp settings with the same hosts and colors.)

I am currently using TST Colored Tabs 0.7 on Firefox 85.0.2 (64-bit) with Tree Style Tab 3.7.0 on Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant