Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NuGet package license as equal as GitHub MIT license #92

Open
bezzad opened this issue Sep 14, 2021 · 1 comment
Open

Update NuGet package license as equal as GitHub MIT license #92

bezzad opened this issue Sep 14, 2021 · 1 comment

Comments

@bezzad
Copy link

bezzad commented Sep 14, 2021

Hi,
I use Fossa to automate the risks out of my open-source Downloader project. My library is used your awesome ShellProgressBar library on the console app samples to show the parallel downloads progresses.
Now I run Fossa and it alerts me like below to not found the license of the ShellProgressBar. So, I checked your project Github license and it's ok. But the license of the Nuget package is a template file. Thus, It has no information about the author and your project.

image

Please update the ShellProgressBar.csproj to populate the license URL, you just had to add the following to your project file:

<PropertyGroup>
  <PackageLicenseUrl>https://raw.githubusercontent.com/Mpdreamz/shellprogressbar/master/LICENSE</PackageLicenseUrl>
  <PackageLicenseExpression>MIT</PackageLicenseExpression>
</PropertyGroup>

And release a new version of NuGet if it's possible for you.
Thanks a lot.

@Mpdreamz
Copy link
Owner

Mpdreamz commented Jun 7, 2022

Awesome project! Great to see this library in action there!

/usr/share/dotnet/sdk/6.0.101/Sdks/NuGet.Build.Tasks.Pack/buildCrossTargeting/NuGet.Build.Tasks.Pack.targets(221,5): error NU5035: The PackageLicenseUrl is being deprecated and cannot be used in conjunction with the PackageLicenseFile or PackageLicenseExpression. [/home/mpdreamz/projects/shellprogressbar/src/ShellProgressBar/ShellProgressBar.csproj]

Adding both PackageLicenseUrl and PackageLicenseExpression is no longer supported by dotnet pack

I fear this is something Fossa needs to add support for too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants