Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child progress bars stay forever if disposed before Tick is called on them #60

Open
jnm2 opened this issue Mar 5, 2020 · 1 comment

Comments

@jnm2
Copy link

jnm2 commented Mar 5, 2020

It appears that I have to use this pattern:

using (var conversionProgress = rewriteProgress.Spawn(1, "Converting Windows PDB to portable..."))
{
    try
    {
        // Something that might throw
    }
    finally
    {
        conversionProgress.Tick(); // Otherwise the conversionProgress bar stays foreverup
    }
}
@jnm2
Copy link
Author

jnm2 commented Mar 5, 2020

I'm less sure now because my workaround above still doesn't seem to work all of the time. There wouldn't be a problem with updating child progress bars from four concurrent tasks, would there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant