-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Prougard rule #44
Comments
Hi, |
Thanks for confirming and considering it for inclusion in the next release. |
Are we using reflection? If not, this should not be stripped and if so is a bug with R8. Adding that proguard rule does not seem right, since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Usage of the library causes app to crash with Android release builds because
R8
removes unused classes or methods from the Ksoup library. Specifically,Builder#onOpenTag
is stripped out, causing a crash when onlyBuilder#onCloseTag
is called in the app.Here's a simplified example of how the library is used in the app:
Adding the following ProGuard rule resolves the issue:
Ideally, this rule could be shipped with the library to avoid manual configuration by consumers?
I'm unsure of the best way forward, but I believe this issue warrants further investigation.
P.S. Thanks for the library, saved me a ton of time parsing html tags in a KMM project
The text was updated successfully, but these errors were encountered: