From c3b7ed8dc043cc9155b7c20c771e54d6442e5b94 Mon Sep 17 00:00:00 2001 From: Maxime Thirouin Date: Fri, 10 Jun 2016 11:24:35 +0200 Subject: [PATCH] Added: ``PageLoading`` now use "Loading..." has a title --- CHANGELOG.md | 7 +++++++ __tests__/index.js | 1 + boilerplate/web_modules/layouts/PageLoading/index.js | 4 ++++ docs/web_modules/layouts/PageLoading/index.js | 4 ++++ 4 files changed, 16 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 77cb147f1..cfe9dfbbd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,10 @@ +## HEAD + +### Boilerplate + +- Added: ``PageLoading`` now use "Loading..." has a title + (@MoOx) + # 0.13.0 - 2016-06-07 ## tl;dr; diff --git a/__tests__/index.js b/__tests__/index.js index d4e48e8a0..e72cb75be 100644 --- a/__tests__/index.js +++ b/__tests__/index.js @@ -80,6 +80,7 @@ test("should have html files", (t) => { t.truthy(includes( "loading/index.html", [ + ">Loading...", "window.__INITIAL_STATE__ = {\"pages\":{\"/loading/\"", ] )) diff --git a/boilerplate/web_modules/layouts/PageLoading/index.js b/boilerplate/web_modules/layouts/PageLoading/index.js index 680c2bba5..686d23927 100644 --- a/boilerplate/web_modules/layouts/PageLoading/index.js +++ b/boilerplate/web_modules/layouts/PageLoading/index.js @@ -1,4 +1,5 @@ import React, { Component } from "react" +import Helmet from "react-helmet" import TopBarProgressIndicator from "react-topbar-progress-indicator" import styles from "./index.css" @@ -16,6 +17,9 @@ export default class PageLoading extends Component { render() { return (
+
diff --git a/docs/web_modules/layouts/PageLoading/index.js b/docs/web_modules/layouts/PageLoading/index.js index 4a34bea97..c07ef3107 100644 --- a/docs/web_modules/layouts/PageLoading/index.js +++ b/docs/web_modules/layouts/PageLoading/index.js @@ -1,4 +1,5 @@ import React, { Component } from "react" +import Helmet from "react-helmet" import TopBarProgressIndicator from "react-topbar-progress-indicator" import Banner from "../../Banner" @@ -18,6 +19,9 @@ export default class PageLoading extends Component { render() { return (
+

{ " " }