-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression for LSReferences in level-set discretization with input domains preservation #150
Comments
Hello, Thanks for the detailed bug report: there is indeed a regression in the iso-value discretization option. In some cases, the non-invertibility of the material map causes problems quite difficult to solve so we have decided (a little too quickly) to impose our users to provide bijective maps... and we didn't see that we were breaking one of the most common use of the multi-material mode. It is hard to simply revert the involved commit as it will broke the usage of this option for other users. I will try to find the time to look at this as soon as possible. Best Regards, |
Hi, I think that I have fixed this regression: non-bijective maps are authorized again as initially and Mmg now raises only a warning. Just note that I hove done nothing to improve the handling of such maps and this option is to use at your own risks: if possible (but I know that it is not always the case), try to provide a bijective map to Mmg. Do not hesitate to test the Thank you by advance, Algiane |
Environment
Problem
Given the files:
mmg.mesh.txt
mmg.sol.txt
mmg.mmg2d.txt
MMG fails using the command:
outputting the message:
Reason
The contents of the
.mmg2d
file are the following:At some point (see #112 and 37774f2) this functionality was removed (intentionally or unintentionally I don't know). However, I don't see why it would be removed since it is quite useful to specify that the new materials will retain their original labels. I use this in my code which uses the master branch but I tested it on the develop branch and came up with this problem. Eventually I would like to upgrade hence the reason for this bug report.
Stack trace
MMG5_Set_multiMat
leads into the problem via the trace:The text was updated successfully, but these errors were encountered: