Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sources have repos that no longer exist #72

Open
Vixeliz opened this issue Feb 18, 2023 · 11 comments
Open

Sources have repos that no longer exist #72

Vixeliz opened this issue Feb 18, 2023 · 11 comments

Comments

@Vixeliz
Copy link

Vixeliz commented Feb 18, 2023

when trying to use flavours update all it fails due to 2 repos no longer existing. Those being ones by aramisgithub

@Vixeliz
Copy link
Author

Vixeliz commented Feb 18, 2023

For now I forked the source repo but I just realized the list.yaml is managed by someone else. So i might open an issue there or you can fork their repo with those two removed.

@Adhalianna
Copy link

I have also noticed the issue. It prevents fetching schemes and templates on a fresh install of flavours

@Misterio77
Copy link
Owner

Hey!

Despite the scary error messages, a few schemes/templates failing to clone should not prevent the others from being cloned (just tested it in a fresh install). I'll see what I can do to improve the error messages a bit.

For anyone browsing this, there's two ways to avoid getting these error messages:

  • Simply comment out the repos from ~/.local/share/flavours/base16/sources/schemes/list.yaml.
  • Alternatively, fork base16-schemes-source and configure ~/.config/flavours/config.toml to use your fork instead (this is possible since Configurable sources (and source hierarchy) #62, but it's missing documentation, the same also applies to templates).

Base16 is in a pretty bad state right now, as Chris apparently went rogue against the community fork. I'll fork the sources for now and let my forks be flavours' defaults. In the near future, I'll see if I can update flavours to use tinted-theming's new formats instead.

@Vixeliz
Copy link
Author

Vixeliz commented Feb 23, 2023

For me at least it seemed when those failed none of the following ones were clones but I may be mistaken

@Vixeliz
Copy link
Author

Vixeliz commented Feb 23, 2023

And commenting out list.ymal(lines) iirc just the reset the file when running flavour update all

@Misterio77
Copy link
Owner

Whenever you run flavours update lists or flavours update all, ~/.local/share/flavours/base16/sources/schemes/list.yaml will be overwritten. In this case (schemes list manually edited), you should use only flavours update schemes.

@windowsrefund
Copy link

I'll see if I can update flavours to use tinted-theming's new formats instead.

Hello. Just wondering if there are any plans to have flavour support tinted-theming/base16-schemes. For the time being, I'm just working around it with a small script to pull the repo into ~/.local/share/flavours/bind16/schemes, build directory names, and move each yaml file into each. Very hackish and lame but it is working for the time being.

@titaniumtraveler
Copy link
Contributor

titaniumtraveler commented Jun 5, 2023

Hello. Just wondering if there are any plans to have flavour support tinted-theming/base16-schemes. For the time being, I'm just working around it with a small script to pull the repo into ~/.local/share/flavours/bind16/schemes, build directory names, and move each yaml file into each. Very hackish and lame but it is working for the time being.

Reading the code of flavours update it seems, that it is possible to manually override the used scheme-sources.

fn get_sources(file: &Path, config: &Config) -> Result<(String, String)> {
// Default repos
let default_s_repo = "https://github.com/chriskempson/base16-schemes-source.git";
let default_t_repo = "https://github.com/chriskempson/base16-templates-source.git";
// config source indicators
let use_config_sources = config.schemes.is_some();
let use_config_templates = config.templates.is_some();
// use available config sources, otherwise use defaults
let (mut s_repo, mut t_repo) =
match (config.schemes.as_ref(), config.templates.as_ref()) {
(Some(s), Some(t)) => (String::from(s), String::from(t)),
(Some(s), None) => (String::from(s), String::from(default_t_repo)),
(None, Some(t)) => (String::from(default_s_repo), String::from(t)),
(None, None) => (String::from(default_s_repo), String::from(default_t_repo)),
};

Though the documentation for that is currently missing from the readme.

@Misterio77
Copy link
Owner

I'd love to support tinted theming's format (all schemes on a single repo), but it's a little hard to implement that while keeping backwards compatibility. It's on my radar though!

Though the documentation for that is currently missing from the readme.

Yup! The PR that introduced it did not document it, so it's still missing for now.

@Sleepful
Copy link

Whenever you run flavours update lists or flavours update all, ~/.local/share/flavours/base16/sources/schemes/list.yaml will be overwritten. In this case (schemes list manually edited), you should use only flavours update schemes.

why not:

  1. Document this in the README
  2. Fix the issue and remove the 404 repos from the source

?

@Sleepful
Copy link

Seems negligent towards new users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants