Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT 1.10.2 Sponge Support? #1264

Open
Zilacon opened this issue May 27, 2017 · 3 comments
Open

TT 1.10.2 Sponge Support? #1264

Zilacon opened this issue May 27, 2017 · 3 comments

Comments

@Zilacon
Copy link

Zilacon commented May 27, 2017

I decided to give TT a try and it doesn't seem to like Sponge very much.
Sponge just spams the console its loading DIM-1 using 200% or more cpu usage until the server is killed.

@LunNova
Copy link
Member

LunNova commented May 29, 2017

Probably due to this patch.

https://github.com/MinimallyCorrect/TickThreading/blob/1.10.2/src/main/java/org/minimallycorrect/tickthreading/mixin/forge/MixinDimensionManager.java

I did it in a lazy way which replaces the entire method, probably wiping out a patch sponge needs.

@john01dav
Copy link

john01dav commented Jun 16, 2017

I run my server with Sponge currently, and it can't break past 16 tps in general due to the sheer number of TEs in the world (warmroast and TickProfiler both show that it isn't anything in particular causing the issues). As such, TickThreading (as it was with Tekkit Lite at least) is exactly what I need (per-world threading woulden't be useful to me since the server only spends a few ms in any world but the main one). As such + to this working with Sponge :)

Also: Is TIckThreading in a usable state (other than Sponge) right now, or is it still an unstable beta not suitable for production? If it's production ready, does it do per-world or per-region/chunk threading?

@LunNova
Copy link
Member

LunNova commented Sep 4, 2017

Still an unstable beta - not even working at all, let alone ready for production!

I have a working version of the DimensionManager patch which doesn't break Sponge now using injectables, will try to keep up compatibility as far as possible for other patches.

I expect there will be some cases with sponge API additions/changes required for thread-safety that are too big to patch... we'll see if that happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants