Favicon by Host

[hamcoremusic]

Don't know is this as already a feature, but I would love to have the same "Hosts" functionalities from the description to work with Favicons!

I have two domains pointing to my server from different "brands" and I would love to have it show the logo for the corresponding brand depending on the URL used.

[stephan-gh]

Everything that works in Default and Personalized also works in Hosts. Just add it next to Description with the correct indentation.

E.g.

Hosts:
  pvp.example.com:
    Default:
      Favicon:
        Files:
        - pvp.png

Looks funny, doesn't it?

[hamcoremusic]

Hi there!

I gave this a try and for some reason it will load from the default category, but when put under a host with a default category, it does not display.

[stephan-gh]

Can you post the full configuration?

[hamcoremusic]

Here is my config: https://pastebin.com/7We2YQc9

I already have the two images in the plugin folder. It will show the default one, but not the hosts ones.

[hamcoremusic]

@Mincrell does that look okay?

[stephan-gh]

It looks fine. Does it show the Description from the host, i.e. &eMake sure you read the &6/rules&e! instead of &bIn partnership with FloMcNasty_TV!?

[hamcoremusic]

As far as I have tested, everything works by host but the Favicon section. I even tried to enable Heads just for kmccraft.world and it still used the default non-host values (the two alternating PNG files).

Description and Hover still seperate based on Host.

[hamcoremusic]

I will note that I am using 1.14.

Don't know if this is a ProtocolLib issue or SLP issue!

[stephan-gh]

Will need to try and reproduce it myself. It should be working fine.