Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code duplication in salt_encrypt/encrypt & salt_decrypt/decrypt #8

Closed
MikhailMS opened this issue May 3, 2021 · 1 comment
Closed

Code duplication in salt_encrypt/encrypt & salt_decrypt/decrypt #8

MikhailMS opened this issue May 3, 2021 · 1 comment
Assignees
@MikhailMS
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@MikhailMS
Copy link
Owner

MikhailMS commented May 3, 2021 •
edited
Loading

Looks like:

  1. Loop in encrypt_data is similar to the one in salt_encrypt_data (was competed back in May 2021)
  2. Loop in decrypt_data is similar to the one in salt_decrypt_data

so there is a potential to move loops into thier own small functions
@MikhailMS MikhailMS added enhancement New feature or request good first issue Good for newcomers labels May 3, 2021
@MikhailMS MikhailMS self-assigned this May 3, 2021
MikhailMS added a commit that referenced this issue May 3, 2021
@MikhailMS
WIP #8
126e57d
@MikhailMS MikhailMS changed the title Code duplication in salt_encrypt/encrypt & salt_decrypt/decryppt Code duplication in salt_encrypt/encrypt & salt_decrypt/decrypt May 3, 2021
@MikhailMS
Copy link
Owner Author

Would be closed in the next release 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MikhailMS MikhailMS

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MikhailMS