Skip to content
This repository has been archived by the owner on Jan 21, 2023. It is now read-only.

feat: add missing automatic layout params #88

Closed
wants to merge 2 commits into from

Conversation

WLun001
Copy link

@WLun001 WLun001 commented Jan 11, 2022

New to python, please help me to review @Midnighter

Midnighter
Midnighter previously approved these changes Jan 23, 2022
Copy link
Owner

@Midnighter Midnighter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for the slow response. Adding these attributes looks good to me.

@Midnighter
Copy link
Owner

Actually, I took a look at the Java and the API definition and these two attributes are not part of the AutomaticLayout, it seems.

@WLun001
Copy link
Author

WLun001 commented Jan 24, 2022

but i able to get it from the UI by inspecting the network tab

https://graphviz.structurizr.com/?view=id&resizePaper=true&rankDirection=TB&rankSeparation=300&nodeSeparation=300&margin=400

@Midnighter
Copy link
Owner

@simonbrowndotje can you comment on what the intention for resizePaper and margin is? From where should that be set?

@WLun001
Copy link
Author

WLun001 commented Jan 24, 2022

I found on the java SDK and the docs

@simonbrowndotje
Copy link

Those are only currently used when manually initiating auto-layout from the Structurizr UI.

Screenshot 2022-01-24 at 11 26 03

@Midnighter Midnighter dismissed their stale review January 24, 2022 10:43

API does not currently support the added attributes.

@Midnighter
Copy link
Owner

@WLun001 I guess this first needs to be a feature request on the Structurizr API then before we can make changes here on the Python SDK.

@WLun001
Copy link
Author

WLun001 commented Jan 24, 2022

I found on the java SDK and the docs

@Midnighter how about this? already on the Java SDK

@Midnighter
Copy link
Owner

The Python package only interacts with the web facing API. So we can only support what is possible through this API.

@WLun001
Copy link
Author

WLun001 commented Jan 26, 2022

@Midnighter I see. So we have to wait the web facing APIs to update

@Midnighter
Copy link
Owner

I will close this as part of a clean up.

@Midnighter Midnighter closed this Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autolayout doesn't support resizePaper and margin
3 participants