Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: List Available Subtitles for Not-Yet-Released Movies #66

Open
1 task done
TJruee opened this issue Mar 29, 2024 · 2 comments
Open
1 task done
Labels
feature-request Request a new feature

Comments

@TJruee
Copy link

TJruee commented Mar 29, 2024

Confirmations

  • I have checked the issues tab, and couldn't find an existing issue with my feature request.

Description

It can be done that it will find the language I chose in "config.toml" even if the subtitles have not yet been released

exmple:
Found movie: Dune: Part Two (2024)
Found Subtitles (9): English, Greek, French, Arabic, Czech,Finnish,Hebrew,Greek,Turkish
Release date (iTunes): 2024-04-16.

New exmple:
Found movie: Godzilla x Kong: The New Empire [2024] (ID: 1733624264)
Found Subtitles (9): English, Greek, French, Arabic, Czech, Finnish, Hebrew, Greek, Turkish.
(If it is possible for the names to be color yellow, that is better)
'Godzilla x Kong: The New Empire' is currently unavailable on iTunes, and will be available on 2024-05-14.

@TJruee TJruee added the feature-request Request a new feature label Mar 29, 2024
@TJruee
Copy link
Author

TJruee commented May 1, 2024

@MichaelYochpaz Is this a good idea?

@MichaelYochpaz
Copy link
Owner

Hey, it's a valid suggestion, but more complicated than it may seem.

Currently, the downloaded subtitles are fetched from the iTunes playlist of the movie (a file that refers to different streams to download, like different video / audio / subtitles tracks), not from the data that's used to display available languages on the movie pages on AppleTV.

When a movie is not available yet, it usually has no playlist (since you can't stream it yet), thus the subtitles that will be available once it's released can't be listed using the current method used.

It's very possible to fetch subtitles data from API's data (the subtitles listed on the AppleTV page), but it requires new additional code specifically for that, and requires the code to check languages that are available specifically for the iTunes channel in case there are multiple channels (read here for more information).

So while it's possible and a valid feature request, it's one that will take some time to implement.
I leave this feature request open for now, but can't guarantee it'll be implemented any time soon.

@MichaelYochpaz MichaelYochpaz changed the title [Feature Request]: Feature idea [Feature Request]: List Available Subtitles for Not-Yet-Released Movies May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request a new feature
Projects
None yet
Development

No branches or pull requests

2 participants