Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Skip forced subtitles not matching original or selected language #45

Open
1 task done
vevv opened this issue Jun 10, 2023 · 4 comments
Open
1 task done
Labels
feature-request Request a new feature

Comments

@vevv
Copy link

vevv commented Jun 10, 2023

Confirmations

  • I have checked the issues tab, and couldn't find an existing issue with my feature request.

Description

Apple has an original language field, could use that to skip forced subs which are for other languages, alternatively to only download forced subs for a language selected by user.

@vevv vevv added the feature-request Request a new feature label Jun 10, 2023
@MichaelYochpaz
Copy link
Owner

Hey, thanks for the suggestions.
Just to be sure, you're asking for an option to filter out "fake" forced subtitles for translated languages (which I believe are usually just title translation?) that aren't the real forced subtitles (which should be only for the original language)?

I know that these exist as I've encountered a few in the past, but do you have an example for such case for testing?

@vevv
Copy link
Author

vevv commented Jun 19, 2023

No, they're often more than title translation, and they're often necessary for the dub watchers, so they shouldn't be skipped by default, but they're not needed for my usecase, so an option to skip them would save me some removing. The option to select language to download forced subtitles for would be useful for others to only download forced subtitles for the audio that they have, or to override potential incorrect "original language" tags.

@MichaelYochpaz
Copy link
Owner

Had no plans to add it by default, I was just asking what's the reason behind it and what's the solution you proposed.

Would a download-only-original-forced config option, that if enabled, will filter out any 'forced' subtitles that aren't in the original language suffice?

Can't guarantee I'll add that yet, as it might be more complicated than it looks.
For example, it might say "Hebrew" is the original language in the metadata of the movie, while the subtitles are named "עברית" ("Hebrew" in Hebrew), and have a language code of "he" or "he-il", which will require some extra work.

@vevv
Copy link
Author

vevv commented Jun 21, 2023

That sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request a new feature
Projects
None yet
Development

No branches or pull requests

2 participants