Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: newline display in signature request content. #24500

Merged
merged 4 commits into from
May 16, 2024
Merged

fix: newline display in signature request content. #24500

merged 4 commits into from
May 16, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented May 13, 2024

Description

Newline is not preserved in re-designed signature pages.

Related issues

Fixes: #24480

Manual testing steps

  1. To to test DAPP
  2. Submit a signature request with new lines
  3. Ensure that new lines are preserved

Screenshots/Recordings

Screenshot 2024-05-13 at 4 20 06 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added team-confirmations-secure-ux-PR PRs from the confirmations team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels May 13, 2024
@jpuri jpuri requested a review from a team as a code owner May 13, 2024 10:50
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri added team-confirmations Push issues to confirmations team and removed team-confirmations-secure-ux-PR PRs from the confirmations team labels May 13, 2024
@jpuri jpuri requested review from a team as code owners May 14, 2024 11:41
@legobeat legobeat requested a review from witmicko May 14, 2024 12:35
@metamaskbot
Copy link
Collaborator

Builds ready [8726a37]
Page Load Metrics (747 ± 566 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint5711684136
domContentLoaded8181231
load4628497471179566
domInteractive8181231
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 25 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@SayaGT
Copy link

SayaGT commented May 14, 2024

Hey @jpuri the original issue has been solved but the text isn't wrapping around and is bleeding out of the window. See screenshot below.
Screenshot 2024-05-14 at 16 55 12

witmicko
witmicko previously approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@witmicko witmicko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jpuri jpuri requested a review from witmicko May 15, 2024 14:14
digiwand
digiwand reviewed May 15, 2024
View reviewed changes
Copy link
Contributor

@digiwand digiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@codecov Codecov
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.48%. Comparing base (cfcbd1e) to head (24c49c2).
Report is 18 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #24500   +/-   ##
========================================
  Coverage    67.48%   67.48%           
========================================
  Files         1288     1288           
  Lines        50153    50153           
  Branches     13023    13023           
========================================
  Hits         33842    33842           
  Misses       16311    16311

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [24c49c2]
Page Load Metrics (918 ± 627 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6812487157
domContentLoaded104616105
load5532629181307627
domInteractive94616105
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 30 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri merged commit 1e80ece into develop May 16, 2024
72 checks passed
@jpuri jpuri deleted the signature_redesign_newline_fix branch May 16, 2024 09:13
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 16, 2024
@metamaskbot metamaskbot added the release-11.18.0 Issue or pull request that will be included in release 11.18.0 label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@digiwand digiwand digiwand approved these changes

@witmicko witmicko Awaiting requested review from witmicko

Assignees
No one assigned
Labels
release-11.18.0 Issue or pull request that will be included in release 11.18.0 team-confirmations Push issues to confirmations team
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signatures redesign - Separate lines within personal sign message
6 participants
@jpuri @metamaskbot @SayaGT @witmicko @pedronfigueiredo @digiwand