Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: When users edit a transaction, the information entered in the destination asset input field may not be preserved as expected #24465

Open
sleepytanya opened this issue May 9, 2024 · 3 comments
Assignees
Labels
send-swap Sev2-normal Normal severity; minor loss of service or inconvenience. team-wallet-ux type-bug

Comments

@sleepytanya
Copy link
Contributor

Describe the bug

Destination asset input isn't remaining intact when transaction is edited.

  • change destination token once (e.g. USDC when sending ETH)
  • change destination token again (e.g. WBTC)
  • click "Continue"
  • click "Edit" to return to Send screen
  • destination asset is appearing as previously selected token

Expected behavior

Screenshots/Recordings

tokenEdit.mov

Steps to reproduce

  1. Start Send transaction
  2. Change destination token once (e.g. USDC when sending ETH)
  3. Change destination token again (e.g. WBTC)
  4. Click "Continue"
  5. Click "Edit" to return to Send screen
  6. Notice destination asset is appearing as previously selected token

Error messages or log output

No response

Version

latest build

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@sleepytanya sleepytanya added type-bug team-wallet-ux swap-send-blocker Issues that block release of the Swap & Send feature labels May 9, 2024
@gauthierpetetin gauthierpetetin added the Sev2-normal Normal severity; minor loss of service or inconvenience. label May 13, 2024
@BZahory
Copy link
Contributor

BZahory commented May 17, 2024

We now bypass this screen all together

@BZahory BZahory self-assigned this May 17, 2024
@sleepytanya
Copy link
Contributor Author

sleepytanya commented May 18, 2024

@BZahory let's not close it yet in case the bypass decision is not final? Or we can close but let's keep the send+swap label.

@BZahory
Copy link
Contributor

BZahory commented May 22, 2024

Downgrading from a blocker since we no longer use the confirmations screen

@BZahory BZahory added send-swap and removed swap-send-blocker Issues that block release of the Swap & Send feature labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
send-swap Sev2-normal Normal severity; minor loss of service or inconvenience. team-wallet-ux type-bug
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

3 participants