Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Quotes are not being fetched during the 'Send' transaction following a fresh installation #24464

Open
sleepytanya opened this issue May 9, 2024 · 3 comments
Open

[Bug]: Quotes are not being fetched during the 'Send' transaction following a fresh installation #24464

sleepytanya opened this issue May 9, 2024 · 3 comments
Assignees
@ejwessel
Labels
regression-develop Regression bug that was found on development branch, but not yet present in production send-swap Sev2-normal Normal severity; minor loss of service or inconvenience. team-wallet-ux type-bug

Comments

@sleepytanya
Copy link
Contributor

sleepytanya commented May 9, 2024 •
edited

Describe the bug

Quotes are not being fetched during the 'Send' transaction following a fresh installation. On the second or third attempt quotes become available.

I do not know any reliable way to reproduce it yet. It doesn't happen often.

Expected behavior

Screenshots/Recordings

noQuotes.mov

Steps to reproduce

  1. Install MetaMask extension
  2. Start Send transaction
  3. Select any tokens
  4. Notice that quotes are unavailable

Error messages or log output

No response

Version

latest build

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response
@sleepytanya sleepytanya added type-bug team-wallet-ux swap-send-blocker Issues that block release of the Swap & Send feature labels May 9, 2024
@ejwessel ejwessel self-assigned this May 9, 2024
@ejwessel ejwessel added send-swap and removed swap-send-blocker Issues that block release of the Swap & Send feature labels May 9, 2024
@ejwessel
Copy link
Contributor

ejwessel commented May 9, 2024

Inconsistent reproducibility. Deescalating from blocker.

@gauthierpetetin gauthierpetetin added the Sev2-normal Normal severity; minor loss of service or inconvenience. label May 13, 2024
@ejwessel
Copy link
Contributor

Screenshot 2024-05-16 at 12 40 11 Screenshot 2024-05-16 at 13 12 40

It looks like an error field within the is null, however the logic looks for a string fails validation otherwise.
When the validation fails undefined is returned, this gives us 0 quotes within MM

@ejwessel ejwessel added the swap-send-blocker Issues that block release of the Swap & Send feature label May 16, 2024
@ejwessel
Copy link
Contributor

#24570

@ejwessel ejwessel mentioned this issue May 16, 2024
Merged
7 tasks
ejwessel added a commit that referenced this issue May 16, 2024
@ejwessel
Fix issue 24464 (#24570)
9ddef50 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24570?quickstart=1)

## **Related issues**

Fixes: #24464

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Signed-off-by: Ethan Wessel <[email protected]>
@ejwessel ejwessel removed the swap-send-blocker Issues that block release of the Swap & Send feature label May 16, 2024
@gauthierpetetin gauthierpetetin added the regression-develop Regression bug that was found on development branch, but not yet present in production label May 22, 2024
BZahory pushed a commit that referenced this issue May 22, 2024
@ejwessel @BZahory
Fix issue 24464 (#24570)
63b725c 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24570?quickstart=1)

## **Related issues**

Fixes: #24464

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Signed-off-by: Ethan Wessel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ejwessel ejwessel

Labels
regression-develop Regression bug that was found on development branch, but not yet present in production send-swap Sev2-normal Normal severity; minor loss of service or inconvenience. team-wallet-ux type-bug
Projects
Bugs by severity
Status: To be fixed
Bugs by team
Status: To be fixed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ejwessel @gauthierpetetin @sleepytanya