-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set data source to handle pd.DataFrame correctly #301
Comments
Hi @bangxiangyong ! Good to see you again. I guess the reason for the conversion was, that as of now, some mechanisms later in the process rely on the quantities being of type |
In the function
set_data_source
ofbase_streams.py
, the handling of pd.DataFrame might not be ideal, considering it converts into a numpy array with the following snippet:This might confuse user and raise an error when the intended output is a Dataframe rather than a numpy array. I believe the conversion to numpy array should be omitted:
Here's the full code for the modified
set_data_source
function.This could be a pull request but i'm quite occupied to start a new pull request atm!
The text was updated successfully, but these errors were encountered: