-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow navigating DataGrid with keyboard when in EditMode="DataGridEditMode.Cell" #5383
Comments
So would you not agree with the current shortcuts and implementation? |
The |
What my users are looking for is "Excel like" editing. Currently, it is very difficult to input a column of values because there is no way to navigate vertically with the keyboard. You have to type your value, then use the mouse to move to the next row in the same column. In Excel and that Syncfusion demo, cell navigation works as described above. You can also use the arrow keys to move between cells. Maybe that could be implemented as an opt-in feature? Or allow the user to customize the keys which are used for navigation? |
Syncfusion has a whole page dedicated to keyboard navigation. There are extra things in there such as inserting or deleting a row, but the cell navigation is a big one for us. I think the current rapid editing feature in Blazorise is very close to be able to used for entering in lots of data for our ERP application |
The way how I see it we would have to change how we do cell editing. Now, when we focus on the cell, it is immediately in edit mode. With keyboard navigation that would have to change and edit mode will happen either on dbl click, or F2 for example. |
It would be nice to have some more opinions from the community on how this should work. Is anyone else using the DataGrid with rapid editing in a production environment? Tagging @oaldrian, @WillianGruber, @cowsen, @rbillot as they have been involved in past issues related to rapid editing. |
We have one client that needs this rapid editing of data in a grid. I checked what the difference in features is and the only thing "missing" from the Blazorise DataGrid would be the arrow key navigation As this feature is mostly intended for large data collections (at least in our case), it would be great if the DataGrid has a "Ultra Narrow" feature which includes the edit components. I know this is possible with custom css, but it would be nice to have it from the get go. The goal there would be also to look like an Excel table. |
That's a bit where I'm at too. I'm currently working on a project that requires extensive editing in grids. I'd hate to ditch Blazorise DataGrid for some other framework. It is so so close to being usable for large data editing. |
Well I just opened Excel, and it so happens that indeed That isn't to say the same should happen in the web world as I don't think that's commonly seen? And again the problem is that indeed Would you guys agree that it makes sense to navigate with the arrows keys by default? |
Enter commits in Excel as well, as it navigates. From my POV it would be sufficient to not have the Enter key navigation.
Yes.
Again, only from my POV, but I think it would be sufficient to have only the arrow keys |
I also think it's acceptable to not use the This is my opinion on how I think editing and navigation should work:
Nice to have features (would possibly be separate feature requests):
This is how ag-grid works. I think it does it well. https://www.ag-grid.com/example/?utm_source=ag-grid-readme&utm_medium=repository&utm_campaign=github @David-Moreira I'm happy to provide feedback once you have a working version of something like this. Just let me know. |
Thank you for your feedback guys. Ok, so it seems like there is consensus with the arrows keys, so that's definitely something we need to take a look at. And I believe that just by providing this feature, this would address your "complaints" and make the feature pretty excel like would it not? As for whether the the cell is in Edit mode right away or not, I'm personally still unsure.
In order to have both, you are right that navigation & edit should be separated. So you guys do think it's best if the cell is highlighted instead while navigating? And shouldn't be in edit mode when it's focused? @stsrki would you also agree with @mtbayley suggestions. |
I am indifferent to what the default should be, but I think there should be a mode where single click is used for selection, and double click for edit. Often there are times when the user wants select a value, but not edit it (for example, when they copy a cell's value)
Yes, Agree
Yes, this would make the grid so much more powerful. I'm not really complaining, just trying to make it better! The improvements to the DataGrid in the last year has been amazing, so please keep up the good work. 👍 |
I agree we should add navigation with arrow keys. I also agree that we will need to have an option to define the selection mode and when to go into edit mode. Single, or double click. This is needed so that users can have more freedom to define the behavior. But, once we are in edit mode, I can already see one thing that might be problematic. If the input field is numeric or date/time type, pressing the Up or Down keys would, by default(native browser behavior), increase or decrease the value. It will not navigate away from it. Excel always uses a "string" type input when editing and only formats it once the edited cell loses focus. I'm not really sure how to handle this. Should we |
An option to prevent default up and down would be nice. I wouldn't say it's critical if we can use the enter key to enter/exit editing mode. |
Yea the more we talk about this, I'm more fond of mtbayley's suggestions and making it so, navigation is independent of edit mode. Basically like the ag grid works. This means, that by default if you are focused on a cell, you can navigate with arrow keys + tabbing. |
I just tried the AG Grid. And found it very intuitive. |
I made a comment about this a few years ago. I wanted to create an official feature request for it.
#855 (comment)
I'd like to be able to navigate with the keyboard within a DataGrid when EditMode="DataGridEditMode.Cell"
Similar to this demo:
https://blazor.syncfusion.com/demos/datagrid/batch-editing
The text was updated successfully, but these errors were encountered: