Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Attached Property "TextFieldAssist.ClearButtonSize" #3754

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

corvinsz
Copy link
Contributor

@corvinsz corvinsz commented Jan 2, 2025

this PR adds a new Attached Property to the class TextFieldAssist called ClearButtonSize, it should fix #3751

@Keboo Keboo self-requested a review January 3, 2025 05:11
Copy link
Member

@Keboo Keboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change but can we apply the sizing to the button itself rather than to the pack icon. After that I think it is good.

@corvinsz
Copy link
Contributor Author

corvinsz commented Jan 3, 2025

You are right, I changed it accordingly.
I also changed the Height & Width of the PackIcon to Auto, otherwise I won't stretch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The CloseCircle Icon of TextFieldAssist. HasClearButton is too small.
2 participants