Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display MDIX version in demo app #3734

Open
corvinsz opened this issue Nov 29, 2024 · 3 comments
Open

Display MDIX version in demo app #3734

corvinsz opened this issue Nov 29, 2024 · 3 comments
Labels
demo app Items that relate to the demo application enhancement up-for-grabs

Comments

@corvinsz
Copy link
Contributor

corvinsz commented Nov 29, 2024

Thoughts on displaying the versions of the libraries (MaterialDesignThemes & MaterialDesignColors) used in the demo app?

It could look something like this:
image

A friend was checking something in the demo and later noticed he was still using an old version. Hence this change would be quite useful.

@corvinsz corvinsz added enhancement evaluation required Items is pending review or evaluation by the team labels Nov 29, 2024
@Keboo
Copy link
Member

Keboo commented Nov 29, 2024

Image doesn't look like it uploaded, but I think it would be a good idea to show the version inside of the demo apps.

The key here will be linking it so that when the demo app is built on the pipeline it uses the version specified there (which should match the assembly version)

@Keboo Keboo added up-for-grabs demo app Items that relate to the demo application and removed evaluation required Items is pending review or evaluation by the team labels Nov 29, 2024
@corvinsz
Copy link
Contributor Author

I reuploaded the image, hopefully everyone can see it now.
For anyone interested in the proposed UI layout, here is the XAML:

<Separator />

<StackPanel Margin="10">
    <TextBlock Style="{StaticResource MaterialDesignHeadline6TextBlock}" Text="Version" />
    <Grid>
        <Grid.ColumnDefinitions>
            <ColumnDefinition />
            <ColumnDefinition Width="auto" />
        </Grid.ColumnDefinitions>
        <Grid.RowDefinitions>
            <RowDefinition />
            <RowDefinition />
        </Grid.RowDefinitions>
        <TextBlock Grid.Row="0"
                   Grid.Column="0"
                   IsEnabled="False"
                   Text="MaterialDesignThemes " />
        <TextBlock Grid.Row="0"
                   Grid.Column="1"
                   Text="5.1.0" />

        <TextBlock Grid.Row="1"
                   Grid.Column="0"
                   IsEnabled="False"
                   Text="MaterialDesignColors " />
        <TextBlock Grid.Row="1"
                   Grid.Column="1"
                   Text="3.1.0" />
    </Grid>
</StackPanel>

@Keboo
Copy link
Member

Keboo commented Dec 1, 2024

I think that looks great, happy to take a PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
demo app Items that relate to the demo application enhancement up-for-grabs
Projects
None yet
Development

No branches or pull requests

2 participants